Conversation
- Note make start prerequisite in make test help text - Add .wp-env/ to .gitignore - Exclude dev files from rsync in build script - Pin @wordpress/env to exact version
* Add plugin name to Docker containers
Exits with an error if Node 20+ is not installed, preventing confusing failures from wp-env.
- Add `make install` target that checks Node 20+ and runs npm install - Disable testsEnvironment in .wp-env.json
- Add `make install` target that checks Node 20+ and runs npm install - Disable testsEnvironment in .wp-env.json
Split the test environment into its own .wp-env.tests.json config file with a dedicated port (8889), replacing the deprecated inline env.tests approach. make up/down now manage both environments.
…ult.cache from zip
Member
|
I've updated the PR description to explain why there are two sites being spawned: port 8888 vs port 8889. |
The plan (docs/plans/2026-02-24-wp-env-local-dev.md) specifies `composer install` as part of the quick-start flow, but it was missing from the Makefile install target. Without it, `make test` fails because vendor/bin/phpunit is not available in the container.
Member
|
TIL about |
Member
|
I've added With that in place, I was able to verify all of the test plan's items. |
…ssing rsync exclude - docs/CONTRIBUTING.md: make start → make install && make up - tests/README.md: make start/stop → make up/down, use make install - Makefile: destroy now tears down both dev and test instances - build-plugin.sh: add .wp-env.tests.json to rsync excludes
- Use exclude.lst as single source for rsync and zip exclusions - Add missing .husky, .psalm, .claude to exclude.lst - Keep vendor excluded from rsync only (needed in final zip) - Add node >=20.0.0 to package.json engines - Add check_node to make up target - Add .claude/ to .gitignore - Fix tests/README.md to reference make test-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@wordpress/envas the local development environment for running WordPress and PHPUnit testsMakefilewrapping wp-env and existing tooling (make install,make up,make test,make help)make upstarts both a dev site (localhost:8888) and an isolated test site (localhost:8889)blueprint.jsonfor WordPress Playground demostests/README.md,docs/CONTRIBUTING.md, andREADME.mdwith new workflowNo changes to CI workflows, test bootstrap, or phpunit.xml.dist.
Test plan
@wordpress/env11.x requirement). Verify withnode --version.make install && make up— verify dev site at localhost:8888 and test site at localhost:8889make test— verify PHPUnit runs in wp-env test containermake help— verify all targets listedmake build— verify.wp-env.json,blueprint.json,Makefileexcluded from zip