defensively checking for a missing widget_id#2923
Open
masteradhoc wants to merge 1 commit intoAutomattic:trunkfrom
Open
defensively checking for a missing widget_id#2923masteradhoc wants to merge 1 commit intoAutomattic:trunkfrom
masteradhoc wants to merge 1 commit intoAutomattic:trunkfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2910
Changes Proposed in this Pull Request
empty()guard on$args['widget_id']inWP_Job_Manager_Widget::get_cached_widget()andcache_widget()to prevent PHP 8+ undefined array key warnings.widget_idis absent,get_cached_widget()returnsfalse(cache miss) andcache_widget()returns early — both fall back gracefully to normal widget rendering without caching.Testing Instructions
E_ALL.undefined array key "widget_id"PHP warnings appear in the error log or on screen.$args['widget_id']is present as expected in a standard WordPress widget context).Release Notes
New or Updated Hooks and Templates
None.
Deprecated Code
None.
Screenshot / Video
N/A — no visual change.