fix: allow check-rust to complete without cargo hack#2588
Open
hippietrail wants to merge 3786 commits intoAutomattic:masterfrom
Open
fix: allow check-rust to complete without cargo hack#2588hippietrail wants to merge 3786 commits intoAutomattic:masterfrom
check-rust to complete without cargo hack#2588hippietrail wants to merge 3786 commits intoAutomattic:masterfrom
Conversation
Bumps [indexmap](https://github.com/indexmap-rs/indexmap) from 2.12.0 to 2.12.1. - [Changelog](https://github.com/indexmap-rs/indexmap/blob/main/RELEASES.md) - [Commits](indexmap-rs/indexmap@2.12.0...2.12.1) --- updated-dependencies: - dependency-name: indexmap dependency-version: 2.12.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [criterion](https://github.com/criterion-rs/criterion.rs) from 0.7.0 to 0.8.0. - [Release notes](https://github.com/criterion-rs/criterion.rs/releases) - [Changelog](https://github.com/criterion-rs/criterion.rs/blob/master/CHANGELOG.md) - [Commits](criterion-rs/criterion.rs@criterion-plot-v0.7.0...criterion-v0.8.0) --- updated-dependencies: - dependency-name: criterion dependency-version: 0.8.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…c#2273) Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.20 to 0.3.22. - [Release notes](https://github.com/tokio-rs/tracing/releases) - [Commits](tokio-rs/tracing@tracing-subscriber-0.3.20...tracing-subscriber-0.3.22) --- updated-dependencies: - dependency-name: tracing-subscriber dependency-version: 0.3.22 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…is closed (Automattic#2282) * fix(chrome-ext): return focus to source element when `SuggestionBox` is closed * test(chrome-ext): make sure focus ends up in the right places * fix(chrome-ext): ignoring a suggestion should result in the right focus as well
* feat: copywritten → copyrighted * fix: `cargo fmt`
Co-authored-by: Elijah Potter <me@elijahpotter.dev>
…2269) * refactor: new `SequenceExpr` and `CharStringExt` methods * refactor: propagate new methods
I've started using `octo.nvim` for various code reviews. It seems to work well with Harper
* fix(core): `SpellCheck` not properly correcting `Generaly` * refactor(core): move higher up * chore(core): `just format` * fix(core): appease Clippy
* feat: wish x can → wish x could * fix: fmt
* fix(core): ensure `news` isn't corrected to `news` * fix(core): remove unused imports * chore(core): update snapshots
harper-brill@1.1.0 harper-comments@1.1.0 harper-core@1.1.0 harper-html@1.1.0 harper-ink@1.1.0 harper-jjdescription@1.1.0 harper-literate-haskell@1.1.0 harper-ls@1.1.0 harper-pos-utils@1.1.0 harper-python@1.1.0 harper-stats@1.1.0 harper-tree-sitter@1.1.0 harper-typst@1.1.0 Generated by cargo-workspaces
* feat(core): `Handful` * feat(core): add several additional rules * refactor(core): combine `ItsContraction` duplicates * fix(core): `ItsContraction` should emit `LintKind::Punctuation` In accordance to part of Automattic#2220 * chore(core): update snapshots * feat(core): many more rules * feat(core): many more * feat(core): `CureFor` * fix(core): merge fallout * feat(core): expand according to feedback * fix(core): appease clippy
* feat: implement Automattic#1135 missing "be" * fix: appease clippy
* Add canonicalize to the dictionary * add British spelling
* feat: implement Automattic#1036 join prefix to word * fix: appease clippy * fix: act on advice in review
Bumps [clap](https://github.com/clap-rs/clap) from 4.5.54 to 4.5.56. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.5.54...clap_complete-v4.5.56) --- updated-dependencies: - dependency-name: clap dependency-version: 4.5.56 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: curate dictionary - bother+mass - company-v - computer -v - +failable - language-v * chore: add and tweak entries +glom +Electron +Tauri OS -O -J * chore: curation: + piccy UK, Aus + iTerm2 * chore: subscript +inflections * chore: +QuickLook, +TextMate, +interop, +nonmutating * chore: +ADT * chore: documentation +mass * chore: curation - deployments +plural - overhung +past * fix: annotate many -ed and -ing verbs
…replacement (Automattic#2617) * fix(chrome-ext): preserve cursor position in generic contenteditable replacement * refactor(chrome-ext): extract shared rich text editor test utilities and add cursor position check * fix(chrome-ext): use page.press('body') for key events in shared test utilities * fix(chrome-ext): revert page.press('body') in testMultipleSuggestionsAndUndo
* feat: add asciidoc to vscode extension * docs: add asciidoc to supported languages
Bumps [bytes](https://github.com/tokio-rs/bytes) from 1.10.1 to 1.11.1. - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](tokio-rs/bytes@v1.10.1...v1.11.1) --- updated-dependencies: - dependency-name: bytes dependency-version: 1.11.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(core): improve debug formatting for `Suggestion` Print words as strings rather than char arrays. * docs(core): add comment for future reference
* refactor(core): use more appropriate return type `lex_catch()` is infallible. By extension, functions that use it as a fallback are also infallible. As such, returning an option is misleading and results in callers having to implement unnecessary error handling. BREAKING CHANGE: Changes the return type of `lex_weir_token`, `lex_english_token`, and `lex_catch`. They now return `FoundToken` instead of `Option<FoundToken>`. Also removes the unused `_source` argument from `lex_catch`. * refactor(core): replace loops with iterators * refactor(core): dedupe similar lexing functions * docs(core): documentation for `lex_with()`
* feat(core): implement initial Weirpack spec * docs(core): write Weirpack spec * feat(cli): allow users to load Weirpacks into the lint command * feat(harper.js): add the ability to load Weirpacks * feat(harper.js): run tests when the Weirpack is loaded * chore: `just format` * feat(web): create initial Weirpack playground * refactor(web): use existing components * refactor(web): toasts into their own component * docs(web): add link to the Weirpack playground * refactor(web): `playground` -> `studio` * feat(web): Studio startup screen * refactor(web): studio into pages * fix(web): add loading indicator and fix lack of refreshing state * refactor(harper.js): move Weirpack tools to `harper.js` * refactor(web): icons into their own components * refactor(web): file explorer into own component * fix(web): label rotation * refactor(web): many things, of which I do not remember * feat: cleanup * refactor: format and simplify * fix(web): drawer and selected file highlight * feat(web): use checkmark button to complete rename * chore: update lockfile * chore: allow larger function * fix(web): build + type errors * fix(web): remaining type issues
…ing suggestion (Automattic#2650) * fix(lint-framework): use targeted text replacement in textarea to preserve cursor and undo * test(chrome-ext): unify test factories across textarea and contenteditable specs * fix(chrome-ext): revert highlight count and increase wait timeout for CI stability
Build tests faster by reducing their opt-level from 3 to 1. Retain opt-level 3 for test dependencies, since those don't need to be rebuilt very often.
Reduces binary size of harper-ls by about ~7MiB.
…ttic#2657) * refactor(harper.js): we do not need named types for Weirpacks * doc: add links and clarify descriptions * chore(harper.js): `just format`
harper-asciidoc@1.6.0 harper-brill@1.6.0 harper-comments@1.6.0 harper-core@1.6.0 harper-html@1.6.0 harper-ink@1.6.0 harper-jjdescription@1.6.0 harper-literate-haskell@1.6.0 harper-ls@1.6.0 harper-pos-utils@1.6.0 harper-python@1.6.0 harper-stats@1.6.0 harper-thesaurus@1.6.0 harper-tree-sitter@1.6.0 harper-typst@1.6.0 Generated by cargo-workspaces
* feat: worth to do → worth doing Fixes Automattic#293 * fix: fmt, happy clippy, uppcase tests * fix: Use a proper `description` * fix: address issues in PR review
Bumps [time](https://github.com/time-rs/time) from 0.3.41 to 0.3.47. - [Release notes](https://github.com/time-rs/time/releases) - [Changelog](https://github.com/time-rs/time/blob/main/CHANGELOG.md) - [Commits](time-rs/time@v0.3.41...v0.3.47) --- updated-dependencies: - dependency-name: time dependency-version: 0.3.47 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Replaces instances of `Span::new_with_len(..., 0)` with `Span::empty(...)`.
* feat(core): added expression references to Weir * docs(core): add entry to the documentation for the new syntax * feat(core): cover all cases in Weir tests + create MissingDeterminer rule * fix(core): edge cases * fix(core): appease clippy
…n-instead-of-fail-without-cargo-hack
…hub.com/hippietrail/harper into warn-instead-of-fail-without-cargo-hack
hippietrail
force-pushed
the
warn-instead-of-fail-without-cargo-hack
branch
from
111b5e8 to
0c28e7d
Compare
Collaborator
Author
|
Messed up this PR with an AI - no idea how to fix it - right now I can't find any other old PRs that are messed up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I noticed lately that when I do
just precommitthat the test comes to an abrupt halt after doing all kinds of heavy testing with a dozen Chromium windows open at once etc. just to tell me I don't havecargo hackinstalled.This PR will instead issue a warning at that point but continue the testing.
instead of failing at this point it will issue the warning
I'm not 100% clear if this is acceptable or not though. Another way would be to check if it's installed at the start of the test so that you don't waste time and system resources only for the test to fail to complete.
I'm not a shell expert and the LLM's first method of checking for the presence of
cargo hackdidn't actually work - so please check carefully!How Has This Been Tested?
Manually.
Checklist