-
Notifications
You must be signed in to change notification settings - Fork 282
feat: add words from fantasy, politics, religion, and adverbs #2643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rauletaveras
wants to merge
9
commits into
Automattic:master
Choose a base branch
from
rauletaveras:second_contribution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
291f3e2
feat: add words from fantasy, politics, religion, and adverbs
rauletaveras 37d67f6
tests
rauletaveras e5fd59f
add details and eliminate todos
rauletaveras 85a6c32
pass tests (hopefully)
rauletaveras fddb5cd
Merge branch 'master' into second_contribution
elijah-potter 2456712
submission commit
rauletaveras 9f9508f
addressing maintainer revisions
rauletaveras 4cb79cf
fix omissions
rauletaveras e24aeb3
fix singular markers in language names
rauletaveras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are irregular plurals that I invented
/9for so using/0onlingua francaabove would be consistent with what I was talking about in the other comment, unlike the ones on the names of the language families.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left
Sonlingua francabecause the plural "linguas francas" is attested. Thank you for your patience.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Smeans "generate a regular plural form for this entry" which will result in "lingua francas" instead of "linguas francas" because Harper only has a few rules for variations of plural endings. You can see them inannotations.json. Native English two-word terms still mostly just pluralize the last word. Anything more exotic needs a manually crafted plural entry.You can test the affixing annotations on the commandline like this:
just getforms lingua francaSorry I didn't spot this in my previous reviews.