chore: add "one fowl swoop" to "one foul swoop", rename from InOneFellSwoop#2758
Open
hippietrail wants to merge 2 commits intoAutomattic:masterfrom
Open
chore: add "one fowl swoop" to "one foul swoop", rename from InOneFellSwoop#2758hippietrail wants to merge 2 commits intoAutomattic:masterfrom
InOneFellSwoop#2758hippietrail wants to merge 2 commits intoAutomattic:masterfrom
Conversation
hippietrail
changed the title
InOneFellSwoop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I noticed that the Weir rule to correct "one fell swoop" only expected the mistake to be "one foul swoop", but "one fowl swoop" is also pretty common.
While working on that I noticed that among the examples I was finding for potential unit tests that "with one fell" swoop was also common. So I renamed the rule to "OneFellSwoop" and removed the preposition from the rule so that it will work in more contexts.
I also noticed there were no tests for the "foul" version so I found and added a unit test for that one too.
How Has This Been Tested?
Two new unit tests, one for each variant.
Checklist