Skip to content

feat: the last days→the last few days#3268

Merged
elijah-potter merged 4 commits into
Automattic:masterfrom
hippietrail:in-the-last-days
Jun 15, 2026
Merged

feat: the last days→the last few days#3268
elijah-potter merged 4 commits into
Automattic:masterfrom
hippietrail:in-the-last-days

Conversation

@hippietrail

Copy link
Copy Markdown
Collaborator

Issues

N/A

Description

I was watching a YouTube video where the presenter was obviously a native German speaker and noticed the very common mistake of German speakers of using expressions like "the last days" to mean not finality, but recent days, or "the last few days".

For native English speakers, "the last days" is most used about the biblical end times or the last days of life, which are not the intended associations when native German speakers are speaking or wring English.

I found that it's almost always this error if it comes after a preposition and is not followed by "of" so I rule out phrases without those properties:

  • My computer has been running hot in the last days. ❌
  • Exactly how long the last days will be is not mentioned in the Bible. ✅
  • Bible prophecies tell of things to look for, like signs, to identify the last days. ✅
  • What happens in the last days of life is different for everyone. ✅

How Has This Been Tested?

I found a bunch of variants for both true positives and true negatives.
There are also a couple of disabled (#[ignore]) examples that the linter doesn't yet handle that future contributors can use to improve the linter.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

elijah-potter
elijah-potter previously approved these changes Jun 15, 2026
# Conflicts:
#	harper-core/default_config.json
@elijah-potter elijah-potter enabled auto-merge June 15, 2026 19:02
@elijah-potter elijah-potter added this pull request to the merge queue Jun 15, 2026
Merged via the queue into Automattic:master with commit 45475a0 Jun 15, 2026
12 checks passed
@hippietrail hippietrail deleted the in-the-last-days branch June 16, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants