feat: the last days→the last few days#3268
Merged
Merged
Conversation
elijah-potter
previously approved these changes
Jun 15, 2026
# Conflicts: # harper-core/default_config.json
elijah-potter
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I was watching a YouTube video where the presenter was obviously a native German speaker and noticed the very common mistake of German speakers of using expressions like "the last days" to mean not finality, but recent days, or "the last few days".
For native English speakers, "the last days" is most used about the biblical end times or the last days of life, which are not the intended associations when native German speakers are speaking or wring English.
I found that it's almost always this error if it comes after a preposition and is not followed by "of" so I rule out phrases without those properties:
How Has This Been Tested?
I found a bunch of variants for both true positives and true negatives.
There are also a couple of disabled (
#[ignore]) examples that the linter doesn't yet handle that future contributors can use to improve the linter.Checklist