You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Treat semicolons as chunk terminators so end-of-chunk expression behavior is consistent with commas and similar punctuation.
This patch:
adds Punctuation::Semicolon to TokenKind::is_chunk_terminator()
adds chunk-splitting tests for comma and semicolon in token_string_ext.rs
switches WrongApostrophe from Chunk to Sentence scope to preserve context after chunk boundary changes
Demo
N/A
How Has This Been Tested?
just test
All relevant Rust/core tests passed.
One local Chrome extension options UI test failed: [chromium] tests/options_structured_rules.spec.ts › structured rule settings › rule dropdown updates only the targeted flat rule
AI Disclosure
I am a human and didn't use any AI.
I used LLM features of my editor, but not an agent.
I used an AI agent interactively.
I am an agent or I got an agent to do the work autonomously.
If Your PR Implements or Enhances a Linter
I made up the sentences in the unit tests.
The sentences in the unit tests were generated by an AI.
I'm using examples from the bug report / feature request.
I collected real-world sentences for the unit tests.
Checklist
I have performed a self-review of my own code
I have added tests to cover my changes
I have considered splitting this into smaller pull requests.
Thanks! Did you try testing everything? just test will test all the integrations as well as just the Rust stuff. I'm a bit worried it could break something unexpectedly. Watch out though as it can bog down your system if you're low on resources. It can open ten browser windows at a time over and over, etc.
Everything I see here makes sense. Since you say all tests pass even with just test that it's surely ready. Thanks!
Oh add that you did that to the testing section of your PR body above too so everyone knows without reading through the comments.
Done for this. Thank you for your advice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #3405
Description
Treat semicolons as chunk terminators so end-of-chunk expression behavior is consistent with commas and similar punctuation.
This patch:
Punctuation::SemicolontoTokenKind::is_chunk_terminator()token_string_ext.rsWrongApostrophefromChunktoSentencescope to preserve context after chunk boundary changesDemo
N/A
How Has This Been Tested?
just test[chromium] tests/options_structured_rules.spec.ts › structured rule settings › rule dropdown updates only the targeted flat ruleAI Disclosure
If Your PR Implements or Enhances a Linter
Checklist