feat: analog/acoustic bike→pushbike/pedal bike#3444
Open
hippietrail wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I heard "acoustic bike" for this first time yesterday and thought it was incredibly dumb. But then I thought maybe it's playful rather than ignorant, which is the case.
But it's still worth a lint for when you want to make a document more standard English.
It handles both "acoustic" and "analog"/"analogue" spellings, and "bike" and "bicycle".
Depending on the dialect, it suggests "pushbike" and "pedal bike", or "bicycle".
Note: It doesn't yet handle the indefinite article changing from "an" to "a".
How Has This Been Tested?
cargo testAI Disclosure
I also used Google Search to convert my version with a loop into a nice functional-style version.
If Your PR Implements or Enhances a Linter
Checklist