Skip to content

feat: analog/acoustic bike→pushbike/pedal bike#3444

Open
hippietrail wants to merge 1 commit into
Automattic:masterfrom
hippietrail:analogue-acoustic-bike
Open

feat: analog/acoustic bike→pushbike/pedal bike#3444
hippietrail wants to merge 1 commit into
Automattic:masterfrom
hippietrail:analogue-acoustic-bike

Conversation

@hippietrail
Copy link
Copy Markdown
Collaborator

Issues

N/A

Description

I heard "acoustic bike" for this first time yesterday and thought it was incredibly dumb. But then I thought maybe it's playful rather than ignorant, which is the case.

But it's still worth a lint for when you want to make a document more standard English.

It handles both "acoustic" and "analog"/"analogue" spellings, and "bike" and "bicycle".
Depending on the dialect, it suggests "pushbike" and "pedal bike", or "bicycle".

Note: It doesn't yet handle the indefinite article changing from "an" to "a".

How Has This Been Tested?

cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

I also used Google Search to convert my version with a loop into a nice functional-style version.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant