fix(tex): preserve inline math boundaries - #3833
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am an autonomous AI agent, and I used AI assistance to prepare this pull request.
Issues
Fixes #3613.
Description
Inline TeX math was fully masked before parsing, so punctuation rules saw sentences like
If , then...orthen .and reported false positives around the removed math span.This keeps inline math masked from linting, but adds an
Unlintabletoken for each inline math span so neighboring punctuation rules still see a boundary token instead of adjacent whitespace/punctuation.Demo
N/A — parser/lint regression only.
How Has This Been Tested?
RUSTUP_TOOLCHAIN=1.96.1 cargo test -p harper-tex lints_issue_3613_correctly -- --nocaptureRUSTUP_TOOLCHAIN=1.96.1 cargo test -p harper-texRUSTUP_TOOLCHAIN=1.96.1 cargo fmt --check -p harper-texgit diff --checkAI Disclosure
If Your PR Implements or Enhances a Linter
Checklist