test(core): cover its built-in possessive regression - #3844
Draft
coyaSONG wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Closes #2609.
Description
Current
masteralready handles the reported sentence correctly after the generalized possessive/participle fix in #2720. This PR adds direct regression coverage for the exact hyphenatedbuilt-insentence from #2609 so that the false positive cannot silently return.This is intentionally test-only; it does not duplicate or alter the existing linter implementation.
Demo
Not applicable; this is a unit-test-only change.
How Has This Been Tested?
cargo test -p harper-core issue_2609— 1 passed, 0 failedCARGO_INCREMENTAL=0 just test-rust— full Rust workspace test suite passedCARGO_INCREMENTAL=0 cargo build -p harper-core --all-targets -q— passedItsContractionenabled —lint_count: 0just formatandcargo fmt -- --check— passedcargo hack --each-featurecombinations, WASM/JS/package builds, Harper.js tests (200), Obsidian tests (21), and VS Code integration tests (35)The monolithic
just precommitcommand was split locally because its generated Rust artifacts exhausted the available disk. The headed Chrome/Firefox suites also exposed unrelated local macOS launch-wrapper/UI timing failures; GitHub Actions remains the integration authority for those suites.AI Disclosure
If Your PR Implements or Enhances a Linter
Checklist