feat(core): add zero-width negation expression - #3850
Open
floze-the-genius wants to merge 1 commit into
Open
Conversation
Collaborator
|
I pasted this code into the branch I was working on when I posted #3848 and it does indeed seem to work. Thank you. I'm requesting a review from somebody much more familiar with this aspect of Harper than I am. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #3848.
Description
Add
expr::Not, a zero-width assertion that succeeds only when its inner expression does not match at the current cursor. Unlikepatterns::Invert, it accepts anyExpr, including anchors such asAnchorStart.This provides the missing building block for rules that should match a phrase everywhere except the beginning of a chunk.
Demo
Not applicable; this is a core expression primitive.
How Has This Been Tested?
CARGO_BUILD_JOBS=1 cargo test -p harper-core expr::not -- --nocapture- 2 passedCARGO_BUILD_JOBS=1 cargo clippy -p harper-core --lib -- -D warnings- passedcargo fmt --all -- --check- passedgit diff --check- passedAI Disclosure
If Your PR Implements or Enhances a Linter
Checklist