fix(core): flag 'get access at' and suggest 'get access to' (#3309) - #3880
Open
hammadmunir959 wants to merge 9 commits into
Open
fix(core): flag 'get access at' and suggest 'get access to' (#3309)#3880hammadmunir959 wants to merge 9 commits into
hammadmunir959 wants to merge 9 commits into
Conversation
Collaborator
|
Thanks for this but could you please use our PR template? Please be sure to fill in the AI sections. We do not ban AI but it helps guide how we review PRs to know how much AI was used. |
Author
|
Updated the PR description to follow the PR template, including the AI Disclosure section. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #3309
Description
Adds a new
ExprLinterrule (GetAccessAt) inharper-corethat catches wrong preposition usage likeget access atand suggestsget access to.Includes false-positive filtering for phrases like
at all,at least, time expressions (at this time,at the moment), and URLs.Demo
N/A (Core linting rule covered by unit tests).
How Has This Been Tested?
Implemented unit tests in
harper-core/src/linting/get_access_at.rscovering both valid corrections and false-positive exclusions. Verified clean execution across the entireharper-coretest suite and CI checks.AI Disclosure
If Your PR Implements or Enhances a Linter
Checklist