Skip to content

fix(core): flag 'get access at' and suggest 'get access to' (#3309) - #3880

Open
hammadmunir959 wants to merge 9 commits into
Automattic:masterfrom
hammadmunir959:fix/get-access-to-rule
Open

fix(core): flag 'get access at' and suggest 'get access to' (#3309)#3880
hammadmunir959 wants to merge 9 commits into
Automattic:masterfrom
hammadmunir959:fix/get-access-to-rule

Conversation

@hammadmunir959

@hammadmunir959 hammadmunir959 commented Jul 25, 2026

Copy link
Copy Markdown

Issues

Fixes #3309

Description

Adds a new ExprLinter rule (GetAccessAt) in harper-core that catches wrong preposition usage like get access at and suggests get access to.
Includes false-positive filtering for phrases like at all, at least, time expressions (at this time, at the moment), and URLs.

Demo

N/A (Core linting rule covered by unit tests).

How Has This Been Tested?

Implemented unit tests in harper-core/src/linting/get_access_at.rs covering both valid corrections and false-positive exclusions. Verified clean execution across the entire harper-core test suite and CI checks.

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

@hippietrail

Copy link
Copy Markdown
Collaborator

Thanks for this but could you please use our PR template? Please be sure to fill in the AI sections. We do not ban AI but it helps guide how we review PRs to know how much AI was used.

@hippietrail hippietrail added the linting Related to lint rules and linter execution label Jul 26, 2026
@hammadmunir959

Copy link
Copy Markdown
Author

Updated the PR description to follow the PR template, including the AI Disclosure section. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linting Related to lint rules and linter execution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should correct "get access at" to "get access to"

2 participants