Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typst Corrections #442

Merged
merged 15 commits into from
Mar 6, 2025
Merged

Conversation

grantlemons
Copy link
Collaborator

There are many issues with Typst support.

Based on #391, so merge that one first.

@grantlemons grantlemons mentioned this pull request Jan 28, 2025
@elijah-potter elijah-potter linked an issue Jan 28, 2025 that may be closed by this pull request
@grantlemons grantlemons marked this pull request as ready for review March 3, 2025 20:32
Copy link
Collaborator

@elijah-potter elijah-potter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give us a brief summary (for posterity) of what problems this PR fixes. I'd like to test your changes locally, but I'm not sure what to look for.

@@ -37,3 +37,4 @@ macro_rules! create_test {
create_test!(complex_document.typ, 0);
create_test!(simplified_document.typ, 0);
create_test!(complex_document_with_spelling_mistakes.typ, 4);
// create_test!(issue_399.typ, 3);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to disable it (rather than remove it), you should add a comment here that explains why.

@grantlemons
Copy link
Collaborator Author

It changes the newlines after some textual elements, such as headers to paragraph breaks, and marks references in text as unlintable.

@elijah-potter elijah-potter merged commit 981ac72 into Automattic:master Mar 6, 2025
4 checks passed
@grantlemons grantlemons deleted the typst-corrections branch March 8, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typst support
2 participants