Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dict): added words to dictionary #847

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ficcdaf
Copy link
Contributor

@ficcdaf ficcdaf commented Mar 7, 2025

Issues

Description

Added some technical terms and other words to the dictionary.

Demo

How Has This Been Tested?

just searchdictfor to check the expansions.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes

@hippietrail
Copy link
Contributor

How Has This Been Tested?

just searchdictfor to check the expansions.

Here's a tip in case you don't know: just searchfor greps the expanded dictionary so might return some coinicidental matches and might miss some expansions if you're not careful and the endings change.

You can also use just getforms with the exact line from dictionary.dict, or the line you're thinking of adding, and will return just the expanded forms of that entry.

Let me know if I should change its comment in the justfile, add it to the docs somewhere, or add missing functionality to it.

@ficcdaf
Copy link
Contributor Author

ficcdaf commented Mar 8, 2025

You can also use just getforms with the exact line from dictionary.dict, or the line you're thinking of adding, and will return just the expanded forms of that entry.
Let me know if I should change its comment in the justfile, add it to the docs somewhere, or add missing functionality to it.

I had no idea. I thought for example just getforms cryptographic should give me all the forms as defined in the dictionary so I was confused as to why it wasn't working. A justfile description and docs update would be stellar.

@hippietrail
Copy link
Contributor

You can also use just getforms with the exact line from dictionary.dict, or the line you're thinking of adding, and will return just the expanded forms of that entry.
Let me know if I should change its comment in the justfile, add it to the docs somewhere, or add missing functionality to it.

I had no idea. I thought for example just getforms cryptographic should give me all the forms as defined in the dictionary so I was confused as to why it wasn't working. A justfile description and docs update would be stellar.

It's funny. As I was writing my reply to you I was thinking it could do that - it's already maybe the longest recipe in the justfile but I think I'll improve it tomorrow. Thanks for the feedback! Is there a place in the docs it would belong?

@hippietrail hippietrail mentioned this pull request Mar 9, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants