feat: implement "ticking time clock" #851
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Automattic#839 Offers "ticking time bomb" for the idiom involving dire consequences. And also offers "ticking clock" to avoid redundant "time clock" in more recent usage where the conseuqences are no so dangerous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #839
Description
Looks for "ticking time clock" and offers a choice of "ticking time bomb" for the idiom involving dire consequences, and "ticking clock" to avoid redundant "time clock" in more recent usage where the consequences are not so dangerous.
I implemented a new
assert_second_suggestion_result()to check against the second suggestion when there are two and the difference is semantically important.How Has This Been Tested?
Added a test for each usage based on real-world sentences I found for the issue report.
Checklist