Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mask out comments beginning with spellchecker:ignore #861

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grantlemons
Copy link
Collaborator

@grantlemons grantlemons commented Mar 9, 2025

Still needs some tests. I'm not sure this is the cleanest way to accomplish this, but I based it on a comment @elijah-potter once made about something similar (I think shebangs).

@grantlemons
Copy link
Collaborator Author

Closes #825

@grantlemons
Copy link
Collaborator Author

Still needs some tests. I'm not sure this is the cleanest way to accomplish this, but I based it on a comment @elijah-potter once made about something similar (I think shebangs).

I was wrong, it was my own suggestion lol, I like elijah's better (making a new masker and wrapping the treesitter masker) so I'll mark this as draft for the time being.

@grantlemons grantlemons marked this pull request as draft March 9, 2025 06:16
@grantlemons
Copy link
Collaborator Author

I made it ignore on

spellchecker:ignore
spellchecker: ignore
spellcheck:ignore
spellchecker: ignore
cspell:ignore
cspell: ignore
harper:ignore
harper: ignore

These are all done with individual .contains() on the text of the comment, so I'm sure there's a better way to do this.

@grantlemons grantlemons marked this pull request as ready for review March 9, 2025 06:52
@grantlemons grantlemons changed the title feat(#825): mask out comments beginning with spellchecker:ignore feat: mask out comments beginning with spellchecker:ignore Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant