-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialect prototyping #925
Open
elijah-potter
wants to merge
24
commits into
master
Choose a base branch
from
dialect-prototyping
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dialect prototyping #925
+2,613
−1,054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2025
This was
linked to
issues
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#345
Description
This is a large patch, so there's a lot to cover:
Dialect
type to represent the 4 major English dialectsWordMetadata
,Token
, andTokenKind
to no longer beCopy
.This affected performance by about -8%.
MutableDictionary
(and by extension theFstDictionary
) to use word hashes as keys in a single map.derived_from
element to theWordMetadata
. This allows linters to determine the base word (the base word forbananas
isbanana
) for an affixed word.hunspell
module torune
. This module will slowly evolve to container a more bespoke dictionary file format. It has already evolved from the hunspell format sufficiently for a name change.MutableDictionary
at runtime using Rune files.en-GB
,en-CA
anden-AU
.Next Steps Before Merge
Before I can feel comfortable merging this PR, there are a couple things that have to happen:
Rune needs to be extended to be able to describe the relationships between words of various dialects (color
->colour
).Edit: the built-in spell check seems to convert between dialects quite well on its own. There isn't any immediate need for manual tagging.