Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Extension Updates #960

Merged
merged 5 commits into from
Mar 25, 2025
Merged

Conversation

mcecode
Copy link
Collaborator

@mcecode mcecode commented Mar 23, 2025

Issues

None in particular

Description

  1. In fix(vscode-plugin): ignore non-existent ".git" files, support untitled/unsaved files on VS Code #927, support for untitled files was introduced, which works well. However, when a user tries to add to their user or file dictionary, it silently errors in the background. Only when the user opens the logs do they see an error. This adds that the user is prompted to save the untitled file first before trying to add words into their user or file dictionary.
  2. Update tests
    • Merge integrationBritish into integration so all integration tests are in just one file
    • Put names for the different uses of the sleep function so we don't have magic numbers anymore
    • Turn on Shellscript test since feat: ignore shebangs #65 was closed

Demo

For 1:

Screencast.webm

How Has This Been Tested?

I wanted to to add an integration test for 1, but VS Code doesn't seem to have an API to check if notifications fire as expected, so all I could do was manual testing. Open to ideas if anyone knows how to make automated tests for that.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes

elijah-potter
elijah-potter previously approved these changes Mar 25, 2025
@elijah-potter elijah-potter added this pull request to the merge queue Mar 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 25, 2025
@elijah-potter elijah-potter enabled auto-merge March 25, 2025 12:54
@elijah-potter elijah-potter added this pull request to the merge queue Mar 25, 2025
Merged via the queue into Automattic:master with commit a1e2c08 Mar 25, 2025
22 checks passed
@mcecode mcecode deleted the vscode-upkeep branch March 26, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants