Remove the launchpad's updated_write_tasklist param (#42560)

* Remove the launchpad's updated_write_tasklist param

The publish a blog project changes have deployed in Calypso, and the
updated_write_tasklist param is now always set to true. This means we
can clean up this temporary flag from Jetpack.

* changelog

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/13960445895

Upstream-Ref: Automattic/jetpack@1794810

Author: p-jackson

CHANGELOG.md

@@ -81,6 +81,7 @@ This is an alpha version! The changes listed here are not final.
 - Launchpad: Replace newsletter preview task with launch task
 - Launchpad: show site title task in updated write launchpad
 - Launchpad: update copy for adding subscribers to a site
+- Launchpad: updated_write_tasklist param no longer needed
 - Launchpad: Update select a design step allowing user to interact with it
 - Launchpad: Update tasks so sites created through onboarding have different design task links
 - Launchpad: verify email task uses heuristic for visibility, regardless of experiment cohort

src/features/launchpad/class-launchpad-task-lists.php

@@ -375,11 +375,10 @@ public function get_all_tasks() {
 	 *
 	 * @param string      $id Task list id.
 	 * @param string|null $launchpad_context Optional. Screen in which launchpad is loading.
-	 * @param bool        $updated_write_tasklist Optional. Whether we're using the updated `write` task list.
 	 *
 	 * @return Task[] Collection of tasks associated with a task list.
 	 */
-	public function build( $id, $launchpad_context = null, $updated_write_tasklist = false ) {
+	public function build( $id, $launchpad_context = null ) {
 		$task_list           = $this->get_task_list( $id );
 		$tasks_for_task_list = array();
 
@@ -396,7 +395,7 @@ public function build( $id, $launchpad_context = null, $updated_write_tasklist =
 			$task_definition = $this->get_task( $task_id );
 
 			// if task can't be found don't add anything
-			if ( $this->is_visible( $task_definition, $launchpad_context, $updated_write_tasklist ) ) {
+			if ( $this->is_visible( $task_definition, $launchpad_context ) ) {
 				$tasks_for_task_list[] = $this->build_task( $task_definition, $launchpad_context );
 			}
 		}
@@ -410,17 +409,15 @@ public function build( $id, $launchpad_context = null, $updated_write_tasklist =
 	 *
 	 * @param Task        $task_definition A task definition.
 	 * @param string|null $launchpad_context Optional. Screen in which launchpad is loading.
-	 * @param bool        $updated_write_tasklist Optional. Whether we're using the updated `write` task list.
 	 * @return boolean True if task is visible, false if not.
 	 */
-	protected function is_visible( $task_definition, $launchpad_context = null, $updated_write_tasklist = false ) {
+	protected function is_visible( $task_definition, $launchpad_context = null ) {
 		if ( empty( $task_definition ) ) {
 			return false;
 		}
 
 		$data = array(
-			'launchpad_context'      => $launchpad_context,
-			'updated_write_tasklist' => $updated_write_tasklist,
+			'launchpad_context' => $launchpad_context,
 		);
 
 		return $this->load_value_from_callback( $task_definition, 'is_visible_callback', true, $data );

src/features/launchpad/launchpad-task-definitions.php

@@ -380,15 +380,6 @@ function wpcom_launchpad_get_task_definitions() {
 			},
 		),
 
-		// Write tasks.
-		'setup_write'                     => array(
-			'get_title'            => function () {
-				return __( 'Set up your site', 'jetpack-mu-wpcom' );
-			},
-			'is_complete_callback' => '__return_true',
-			'is_disabled_callback' => '__return_true',
-		),
-
 		// Publish a Blog tasks.
 		'complete_profile'                => array(
 			'get_title'            => function () {
@@ -680,18 +671,6 @@ function wpcom_launchpad_get_task_definitions() {
 				return '/subscribers/' . $data['site_slug_encoded'] . '#add-subscribers';
 			},
 		),
-		'add_first_subscribers'           => array(
-			// We do not want this mapped to the 'subscribers_added' task, since this task supports
-			// being marked as complete in situations where subscribers are not added.
-			'get_title'            => function () {
-				return __( 'Add subscribers', 'jetpack-mu-wpcom' );
-			},
-			'is_complete_callback' => 'wpcom_launchpad_is_add_first_subscribers_completed',
-			'is_visible_callback'  => '__return_true',
-			'get_calypso_path'     => function ( $task, $default, $data ) {
-				return '/subscribers/' . $data['site_slug_encoded'] . '#add-subscribers';
-			},
-		),
 		'add_subscribe_block'             => array(
 			'get_title'            => function () {
 				return __( 'Add the Subscribe Block to your site', 'jetpack-mu-wpcom' );
@@ -2414,16 +2393,12 @@ function wpcom_launchpad_is_front_page_updated_visible() {
 /**
  * Determine `site_title` task visibility. The task is not visible if the name was already set.
  *
- * @param Task  $task The task data.
- * @param bool  $is_visible Whether the task is currently visible.
- * @param array $data Metadata about the launchpad.
- *
  * @return bool True if we should show the task, false otherwise.
  */
-function wpcom_launchpad_is_site_title_task_visible( $task, $is_visible, $data ) {
+function wpcom_launchpad_is_site_title_task_visible() {
 	// Hide the task if it's already completed on write intent
 	if (
-		( 'launched' === get_option( 'launch-status' ) || ! $data['updated_write_tasklist'] ) &&
+		( 'launched' === get_option( 'launch-status' ) ) &&
 		get_option( 'site_intent' ) === 'write' &&
 		wpcom_launchpad_is_task_option_completed( array( 'id' => 'site_title' ) )
 	) {
@@ -2800,25 +2775,6 @@ function wpcom_launchpad_is_domain_customize_completed( $task, $default ) {
 	return $default;
 }
 
-/**
- * Determines whether the add_first_subscribers task is complete by checking both the task option
- * and related tasks like subscribers_added and import_subscribers.
- *
- * This exists because we need a 1-way relationship between these tasks: completion of other
- * subscriber tasks implies add_first_subscribers is completed, but completion of
- * add_first_subscribers does not imply completion of other subscriber tasks. This is because
- * add_first_subscribers is allowed to be marked complete at times when no subscribers are actually
- * added, and why using id_map here will not work since it creates a 2-way relationship.
- *
- * @param Task $task    The Task object.
- * @return bool True if either condition is met.
- */
-function wpcom_launchpad_is_add_first_subscribers_completed( $task ) {
-	return wpcom_launchpad_is_task_option_completed( $task )
-		|| wpcom_is_checklist_task_complete( 'subscribers_added' )
-		|| wpcom_is_checklist_task_complete( 'import_subscribers' );
-}
-
 /**
  * Mark `domain_claim`, `domain_upsell`, and `domain_upsell_deferred` tasks complete
  * when a domain product is activated.

src/features/launchpad/launchpad.php

@@ -139,21 +139,6 @@ function wpcom_launchpad_get_task_list_definitions() {
 			'is_enabled_callback' => 'wpcom_launchpad_get_fullscreen_enabled',
 		),
 		'write'                   => array(
-			'get_title'           => function () {
-				return __( 'Next steps for your site', 'jetpack-mu-wpcom' );
-			},
-			'task_ids'            => array(
-				'setup_write',
-				'design_completed',
-				'plan_selected',
-				'verify_email',
-				'add_first_subscribers',
-				'first_post_published',
-				'site_launched',
-			),
-			'is_enabled_callback' => 'wpcom_launchpad_get_fullscreen_enabled',
-		),
-		'updated-write-tasklist'  => array(
 			'get_title'           => function () {
 				return __( 'Next steps for your site', 'jetpack-mu-wpcom' );
 			},
@@ -504,16 +489,15 @@ function wpcom_is_checklist_task_complete( $task_id ) {
  *
  * @param string      $checklist_slug Checklist slug.
  * @param string|null $launchpad_context Optional. Screen where Launchpad is loading.
- * @param bool        $updated_write_tasklist Optional. Whether we're using the updated `write` task list.
  *
  * @return Task[] Collection of tasks for a given checklist
  */
-function wpcom_get_launchpad_checklist_by_checklist_slug( $checklist_slug, $launchpad_context = null, $updated_write_tasklist = false ) {
+function wpcom_get_launchpad_checklist_by_checklist_slug( $checklist_slug, $launchpad_context = null ) {
 	if ( ! $checklist_slug ) {
 		return array();
 	}
 
-	return wpcom_launchpad_checklists()->build( $checklist_slug, $launchpad_context, $updated_write_tasklist );
+	return wpcom_launchpad_checklists()->build( $checklist_slug, $launchpad_context );
 }
 
 // TODO: Write code p2 post or dotcom post

src/features/wpcom-endpoints/class-wpcom-rest-api-v2-endpoint-launchpad.php

@@ -62,12 +62,6 @@ public function register_routes() {
 							'required'    => false,
 							'default'     => array(),
 						),
-						'updated_write_tasklist'     => array(
-							'description' => 'Enable the updated write tasklist, for testing purposes',
-							'type'        => 'boolean',
-							'required'    => false,
-							'default'     => false,
-						),
 					),
 				),
 				array(
@@ -179,21 +173,13 @@ public function get_data( $request ) {
 			$switched_locale = switch_to_locale( $locale );
 		}
 
-		$checklist_slug         = isset( $request['checklist_slug'] ) ? $request['checklist_slug'] : get_option( 'site_intent' );
-		$use_goals              = isset( $request['use_goals'] ) ? $request['use_goals'] : false;
-		$updated_write_tasklist = isset( $request['updated_write_tasklist'] ) ? $request['updated_write_tasklist'] : false;
+		$checklist_slug = isset( $request['checklist_slug'] ) ? $request['checklist_slug'] : get_option( 'site_intent' );
+		$use_goals      = isset( $request['use_goals'] ) ? $request['use_goals'] : false;
 
 		$launchpad_context = isset( $request['launchpad_context'] )
 			? $request['launchpad_context']
 			: null;
 
-		if ( $updated_write_tasklist && $checklist_slug === 'write' ) {
-			// The updated_write_tasklist param facilitates a call-for-testing where we want
-			// to try out changes to the write tasks. The intention is that `updated-write-tasklist`
-			// will replace `write`, at which point updated_write_tasklist should be removed.
-			$checklist_slug = 'updated-write-tasklist';
-		}
-
 		if ( $use_goals ) {
 			// The user must be part of a cohort which should deterine which checklist to show soley on
 			// goal selection, not the "intent".
@@ -205,7 +191,7 @@ public function get_data( $request ) {
 			'site_intent'        => get_option( 'site_intent' ),
 			'launchpad_screen'   => get_option( 'launchpad_screen' ),
 			'checklist_statuses' => get_option( 'launchpad_checklist_tasks_statuses', array() ),
-			'checklist'          => wpcom_get_launchpad_checklist_by_checklist_slug( $checklist_slug, $launchpad_context, $updated_write_tasklist ),
+			'checklist'          => wpcom_get_launchpad_checklist_by_checklist_slug( $checklist_slug, $launchpad_context ),
 			'is_enabled'         => wpcom_get_launchpad_task_list_is_enabled( $checklist_slug ),
 			'is_dismissed'       => wpcom_launchpad_is_task_list_dismissed( $checklist_slug ),
 			'is_dismissible'     => wpcom_launchpad_is_task_list_dismissible( $checklist_slug ),