-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms: add button color and typography global style controls #41141
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting the ball rolling on this effort @simison 👍
It might be a touch early to review this one but I've taken it for a quick spin all the same.
While testing I noticed the following:
Text align support not working correctly in the editor
- Text alignments set in global styles don't work in the editor due to a wrapper around the label elements
- Alignments applied to the form block instance don't override those set in global styles when it comes to non-field blocks within the form e.g. Heading or Paragraph blocks
Limited typography supports
In Gutenberg, there is an ongoing effort to provide greater design tool consistency across blocks. This mostly centers around adopting all block supports for all blocks where it makes sense.
Given the desire to improve the form fields and adopt further block supports there, it might be a good idea to adopt all the other applicable typography supports here on the form block too e.g. font family, weight, style, text transform etc.
I'm happy to help out here in any way I can. Let me know what might work for you.
Part of #41120
Needs more testing how these controls make sense and if they work well.
It should probably be split into two separate PRs for button colour and typography.
Proposed changes:
typography
supportcolor.button
supportGlobal styles editor
Before
After
Block editor
Before
After
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: