Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Media: Integrate external media modal #41160

Closed
wants to merge 17 commits into from

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Jan 17, 2025

Related to https://github.com/Automattic/dotcom-forge/issues/10251, #41078

Proposed changes:

  • Integrate external media modal

TODO

  • Fix CSS
  • Fix ERR_BLOCKED_BY_RESPONSE.NotSameOrigin for Openverse (It's resolved automatically...)
  • Display success notice
  • Move to Jetpack and enable it for WP.com users first

The current screenshot

Google Photo Pexels free photos Openverse
image image image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the feat/wpcom-external-media-import-modal branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack feat/wpcom-external-media-import-modal
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin feat/wpcom-external-media-import-modal
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for February 4, 2025 (scheduled code freeze on February 4, 2025).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 17, 2025
@arthur791004 arthur791004 force-pushed the feat/wpcom-external-media-import-modal branch from edf82fd to 79c9793 Compare January 20, 2025 05:49
@github-actions github-actions bot added [Extension] External Media Extend all block editor media tools to support external providers [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 20, 2025
@arthur791004 arthur791004 changed the title WIP Import Media: Integrate external media modal Import Media: Integrate external media modal Jan 20, 2025
@arthur791004 arthur791004 force-pushed the feat/move-external-media-to-package branch 14 times, most recently from 2bf09a6 to 007b505 Compare January 23, 2025 10:31
@arthur791004 arthur791004 changed the base branch from feat/move-external-media-to-package to trunk January 23, 2025 11:54
@github-actions github-actions bot added [Block] Blogroll [Block] Pay With Paypal aka Simple Payments [Block] Send a message [Block] VideoPress [Extension] Post Publish QR Post Panel [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Social Issues about the Jetpack Social plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Tests] Includes Tests labels Jan 23, 2025
@arthur791004
Copy link
Contributor Author

Closing it in favor of #41078 since we plan to move all of the external media codebase to the new package.

@arthur791004 arthur791004 deleted the feat/wpcom-external-media-import-modal branch January 23, 2025 13:23
@github-actions github-actions bot removed [Status] In Progress [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Blogroll [Block] Pay With Paypal aka Simple Payments [Block] Send a message [Block] VideoPress [Extension] External Media Extend all block editor media tools to support external providers [Extension] Post Publish QR Post Panel [JS Package] Shared Extension Utils [Package] Jetpack mu wpcom WordPress.com Features [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Social Issues about the Jetpack Social plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Plugin] Wpcomsh RNA [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant