Jetpack AI: Updates / clean up to Jetpack AI assistant sidebar #41161

mwatson · 2025-01-17T16:52:41Z

Fixes #41007 and #41140

Proposed changes:

As outlined in this P2 post: p1HpG7-uEC-p2
Adjustments and changes to put the Jetpack AI Assistant sidebar more inline with the rest of Gutenberg

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

P2: p1HpG7-uEC-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

Check out the Jetpack AI Assistant sidebar and observe that it looks how it's always looked
Check out and build this branch or otherwise spin it up somewhere
Refresh and look at the Jetpack AI Sidebar
The sidebar should more or less behave the same but look more like the designs in the above P2
Verify that the sidebar behaves as you'd expect. There should be no major changes to functionality.
Check for typos! I already found one 😓
The changes are not pixel perfect as I was working with existing components that have their own styling options.
Verify that a message that says "The following features require content to work." appears at the top of the sidebar if the current post is empty and disappears when something is added, and then re-appears if you remove all content.

Screenshots

* Buttons now have 100% width and are 40px tall * Updated text in various places * Added message that displays when a post has no content * Cleaned up spacing in a few places * Changed color of some text

…e brief controls

…rief styling cleanup

mwatson · 2025-01-17T16:53:06Z

...pack/extensions/plugins/ai-assistant-plugin/components/ai-assistant-plugin-sidebar/index.tsx

+			{ isPostEmpty && (
+				<PanelRow className="jetpack-ai-sidebar__warning-content">
+					<Notice isDismissible={ false } status="warning">
+						{ __( 'The following features requie content to work.', 'jetpack' ) }


Typo on "require" 😅

github-actions · 2025-01-17T16:53:32Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/jetpack-ai-sidebar-improvements branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/jetpack-ai-sidebar-improvements

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-01-17T16:53:57Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for February 4, 2025 (scheduled code freeze on February 4, 2025).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

dhasilva

LGTM, well done!

mwatson added 4 commits January 15, 2025 16:46

Updates / clean up to Jetpack AI assistant sidebar

faf638c

* Buttons now have 100% width and are 40px tall * Updated text in various places * Added message that displays when a post has no content * Cleaned up spacing in a few places * Changed color of some text

Replacing custom warning with Notice component, move score below writ…

291002b

…e brief controls

Switching to use isEditedPostEmpty instead of usePostContent, Write B…

8360654

…rief styling cleanup

changelog

f7cdc8e

mwatson added the [Status] Needs Team Review label Jan 17, 2025

mwatson requested a review from a team January 17, 2025 16:52

mwatson self-assigned this Jan 17, 2025

mwatson commented Jan 17, 2025

View reviewed changes

github-actions bot added [Extension] AI Assistant Plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 17, 2025

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 17, 2025

mwatson added the [Type] Task label Jan 17, 2025

mwatson changed the title ~~Update/jetpack ai sidebar improvements~~ Jetpack AI: Updates / clean up to Jetpack AI assistant sidebar Jan 17, 2025

Fixing typo

b9420f5

dhasilva approved these changes Jan 17, 2025

View reviewed changes

dhasilva removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jetpack AI: Updates / clean up to Jetpack AI assistant sidebar #41161

Jetpack AI: Updates / clean up to Jetpack AI assistant sidebar #41161

mwatson commented Jan 17, 2025

mwatson Jan 17, 2025

github-actions bot commented Jan 17, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited

Loading

dhasilva left a comment

Jetpack AI: Updates / clean up to Jetpack AI assistant sidebar #41161

Are you sure you want to change the base?

Jetpack AI: Updates / clean up to Jetpack AI assistant sidebar #41161

Conversation

mwatson commented Jan 17, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Screenshots

mwatson Jan 17, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 17, 2025 • edited Loading

github-actions bot commented Jan 17, 2025 • edited Loading

dhasilva left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 17, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited

Loading