Phan: functionify and statusify exit() and die()

projects/packages/analyzer/changelog/fix-functionify_and_statusify_exit_and_die

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Code: Use function-style exit() and die() with a default status code of 0.

projects/packages/analyzer/scripts/jetpack-svn.php

@@ -30,7 +30,7 @@
 
 if ( ! file_exists( $external_repo_path ) ) {
 	echo "Need a path of another codebase to compare Jetpack changes against.\n";
-	exit;
+	exit( 0 );
 }
 
 // tmp paths.

projects/packages/autoloader/changelog/fix-functionify_and_statusify_exit_and_die

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Code: Use function-style exit() and die() with a default status code of 0.

projects/packages/autoloader/src/CustomAutoloaderPlugin.php

@@ -104,7 +104,7 @@ public function postAutoloadDump( Event $event ) {
 			$this->io->writeError( "\n<error>An error occurred while generating the autoloader files:", true );
 			$this->io->writeError( 'The project\'s composer.json or composer environment set a non-default vendor directory.', true );
 			$this->io->writeError( 'The default composer vendor directory must be used.</error>', true );
-			exit();
+			exit( 0 );
 		}
 
 		$installationManager = $this->composer->getInstallationManager();
@@ -174,7 +174,7 @@ private function isRequiredByRoot() {
 
 		if ( empty( $requires ) ) {
 			$this->io->writeError( "\n<error>The package is not required and this should never happen?</error>", true );
-			exit();
+			exit( 0 );
 		}
 
 		foreach ( $requires as $require ) {

projects/packages/backup/changelog/fix-functionify_and_statusify_exit_and_die

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Code: Use function-style exit() and die() with a default status code of 0.

projects/packages/backup/src/class-jetpack-backup.php

@@ -12,7 +12,7 @@
 namespace Automattic\Jetpack\Backup\V0005;
 
 if ( ! defined( 'ABSPATH' ) ) {
-	exit;
+	exit( 0 );
 }
 
 use Automattic\Jetpack\Admin_UI\Admin_Menu;

projects/packages/classic-theme-helper/changelog/fix-functionify_and_statusify_exit_and_die

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Code: Use function-style exit() and die() with a default status code of 0.

projects/packages/classic-theme-helper/src/custom-post-types/class-nova-restaurant.php

@@ -831,7 +831,7 @@ public function maybe_reorder_menu_items() {
 				admin_url( 'edit.php' )
 			);
 			wp_safe_redirect( $redirect );
-			exit;
+			exit( 0 );
 		}
 
 		/**
@@ -1036,7 +1036,7 @@ public function handle_menu_item_actions() {
 				admin_url( 'edit.php' )
 			);
 			wp_safe_redirect( $redirect );
-			exit;
+			exit( 0 );
 		}
 
 		/**
@@ -1138,7 +1138,7 @@ public function add_many_new_items_page_load() {
 				&& 'POST' === strtoupper( sanitize_text_field( wp_unslash( $_SERVER['REQUEST_METHOD'] ) ) )
 			) {
 				$this->process_form_request();
-				exit;
+				exit( 0 );
 			}
 
 			$this->enqueue_many_items_scripts();
@@ -1234,11 +1234,11 @@ public function process_form_request() {
 			endforeach;
 
 			if ( $is_ajax ) {
-				exit;
+				exit( 0 );
 			}
 
 			wp_safe_redirect( admin_url( 'edit.php?post_type=' . self::MENU_ITEM_POST_TYPE ) );
-			exit;
+			exit( 0 );
 		}
 
 		/**

projects/packages/connection/changelog/fix-functionify_and_statusify_exit_and_die

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Code: Use function-style exit() and die() with a default status code of 0.

projects/packages/connection/legacy/class-jetpack-ixr-client.php

@@ -16,7 +16,7 @@
  * Disable direct access.
  */
 if ( ! defined( 'ABSPATH' ) ) {
-	exit;
+	exit( 0 );
 }
 
 if ( ! class_exists( IXR_Client::class ) ) {

projects/packages/connection/src/class-manager.php

@@ -317,7 +317,7 @@ public function alternate_xmlrpc() {
 		nocache_headers();
 		$wp_xmlrpc_server->serve_request();
 
-		exit;
+		exit( 0 );
 	}
 
 	/**
@@ -935,7 +935,7 @@ public function connect_user( $user_id = null, $redirect_url = null ) {
 
 		// Using wp_redirect intentionally because we're redirecting outside.
 		wp_redirect( $this->get_authorization_url( $user, $redirect_url ) ); // phpcs:ignore WordPress.Security.SafeRedirect
-		exit();
+		exit( 0 );
 	}
 
 	/**

projects/packages/connection/src/class-partner-coupon.php

@@ -15,7 +15,7 @@
  * Disable direct access.
  */
 if ( ! defined( 'ABSPATH' ) ) {
-	exit;
+	exit( 0 );
 }
 
 /**

projects/packages/connection/src/class-webhooks.php

@@ -163,7 +163,7 @@ public function handle_authorize_redirect() {
 	 * @return never
 	 */
 	protected function do_exit() {
-		exit;
+		exit( 0 );
 	}
 
 	/**

projects/packages/connection/src/sso/class-sso.php

@@ -191,7 +191,7 @@ public function maybe_logout_user() {
 			Helpers::delete_connection_for_user( $current_user->ID );
 			wp_logout();
 			wp_safe_redirect( wp_login_url() );
-			exit;
+			exit( 0 );
 		}
 	}
 
@@ -491,7 +491,7 @@ public function login_init() {
 
 				$tracking->record_user_event( 'sso_login_redirect_success' );
 				wp_safe_redirect( $sso_url );
-				exit;
+				exit( 0 );
 			}
 		} elseif ( Helpers::display_sso_form_for_action( $action ) ) {
 
@@ -509,7 +509,7 @@ public function login_init() {
 				$sso_url = $this->get_sso_url_or_die( $reauth );
 				$tracking->record_user_event( 'sso_login_redirect_bypass_success' );
 				wp_safe_redirect( $sso_url );
-				exit;
+				exit( 0 );
 			}
 
 			$this->display_sso_login_form();
@@ -969,15 +969,15 @@ public function handle_login() {
 						admin_url()
 					)
 				);
-				exit;
+				exit( 0 );
 			}
 
 			add_filter( 'allowed_redirect_hosts', array( Helpers::class, 'allowed_redirect_hosts' ) );
 			wp_safe_redirect(
 			/** This filter is documented in core/src/wp-login.php */
 				apply_filters( 'login_redirect', $redirect_to, $_request_redirect_to, $user )
 			);
-			exit;
+			exit( 0 );
 		}
 
 		add_filter( 'jetpack_sso_default_to_sso_login', '__return_false' );
@@ -1207,7 +1207,7 @@ public function maybe_authorize_user_after_sso() {
 
 		add_filter( 'allowed_redirect_hosts', array( Helpers::class, 'allowed_redirect_hosts' ) );
 		wp_safe_redirect( $connect_url );
-		exit;
+		exit( 0 );
 	}
 
 	/**

projects/packages/connection/src/webhooks/class-authorize-redirect.php

@@ -63,7 +63,7 @@ function ( $domains ) {
 
 		if ( ! $dest_url || ( 0 === stripos( $dest_url, 'https://jetpack.com/' ) && 0 === stripos( $dest_url, 'https://wordpress.com/' ) ) ) {
 			// The destination URL is missing or invalid, nothing to do here.
-			exit;
+			exit( 0 );
 		}
 
 		// The user is either already connected, or finished the connection process.
@@ -73,12 +73,12 @@ function ( $domains ) {
 			}
 
 			wp_safe_redirect( $dest_url );
-			exit;
+			exit( 0 );
 		} elseif ( ! empty( $_GET['done'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
 			// The user decided not to proceed with setting up the connection.
 
 			wp_safe_redirect( Admin_Menu::get_top_level_menu_item_url() );
-			exit;
+			exit( 0 );
 		}
 
 		$redirect_args = array(
@@ -94,7 +94,7 @@ function ( $domains ) {
 		}
 
 		wp_safe_redirect( $this->build_authorize_url( add_query_arg( $redirect_args, admin_url( 'admin.php' ) ) ) );
-		exit;
+		exit( 0 );
 	}
 
 	/**

projects/packages/forms/changelog/fix-functionify_and_statusify_exit_and_die

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Code: Use function-style exit() and die() with a default status code of 0.

projects/packages/forms/src/contact-form/class-admin.php

@@ -439,7 +439,7 @@ public function grunion_display_form_view() {
 		if ( current_user_can( 'edit_posts' ) ) {
 			Form_View::display();
 		}
-		exit;
+		exit( 0 );
 	}
 
 	/**
@@ -549,7 +549,7 @@ public function grunion_handle_bulk_spam() {
 
 		if ( empty( $_REQUEST['post'] ) ) {
 			wp_safe_redirect( wp_get_referer() );
-			exit;
+			exit( 0 );
 		}
 
 		$post_ids = array_map( 'intval', $_REQUEST['post'] );
@@ -583,7 +583,7 @@ public function grunion_handle_bulk_spam() {
 
 		$redirect_url = add_query_arg( 'message', 'marked-spam', wp_get_referer() );
 		wp_safe_redirect( $redirect_url );
-		exit;
+		exit( 0 );
 	}
 
 	/**
@@ -1255,7 +1255,7 @@ public function grunion_ajax_spam() {
 		}
 
 		echo $status_html; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- we're building the html to echo.
-		exit;
+		exit( 0 );
 	}
 
 	/**

projects/packages/forms/src/contact-form/class-contact-form-plugin.php

@@ -776,7 +776,7 @@ public function ajax_request() {
 			);
 		}
 
-		die;
+		die( 0 );
 	}
 
 	/**
@@ -1828,7 +1828,7 @@ public function download_feedback_as_csv() {
 		fclose( $output ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_system_operations_fclose
 
 		$this->record_tracks_event( 'forms_export_responses', array( 'format' => 'csv' ) );
-		exit();
+		exit( 0 );
 	}
 
 	/**

projects/packages/forms/src/contact-form/class-contact-form.php

@@ -1635,7 +1635,7 @@ public function process_submission() {
 
 		// phpcs:ignore WordPress.Security.SafeRedirect.wp_redirect_wp_redirect -- We intentially allow external redirects here.
 		wp_redirect( $redirect );
-		exit;
+		exit( 0 );
 	}
 
 	/**

projects/packages/forms/src/dashboard/class-dashboard-view-switch.php

@@ -251,7 +251,7 @@ public function handle_preferred_view() {
 
 		update_user_option( get_current_user_id(), 'jetpack_forms_admin_preferred_view', $view );
 		wp_safe_redirect( remove_query_arg( 'dashboard-preferred-view' ) );
-		exit;
+		exit( 0 );
 	}
 
 	/**

projects/packages/jetpack-mu-wpcom/changelog/fix-functionify_and_statusify_exit_and_die

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Code: Use function-style exit() and die() with a default status code of 0.

projects/packages/jetpack-mu-wpcom/src/features/coming-soon/coming-soon.php

@@ -236,6 +236,6 @@ function coming_soon_page( $template ) {
 	}
 
 	render_fallback_coming_soon_page();
-	die();
+	die( 0 );
 }
 add_filter( 'template_include', __NAMESPACE__ . '\coming_soon_page' );

projects/packages/jetpack-mu-wpcom/src/features/custom-css/csstidy/class.csstidy.php

@@ -526,7 +526,7 @@ public function write( $filename, $formatted = false, $doctype = 'xhtml1.1', $ex
 			$madedir = mkdir( 'temp' ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_system_operations_mkdir
 			if ( ! $madedir ) {
 				print 'Could not make directory "temp" in ' . __DIR__;
-				exit;
+				exit( 0 );
 			}
 		}
 		$handle = fopen( 'temp/' . $filename, 'w' ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_system_operations_fopen

projects/packages/jetpack-mu-wpcom/src/features/custom-css/custom-css.php

@@ -79,7 +79,7 @@ public static function print_linked_custom_css() {
 			header( 'Content-type: text/css' );
 			header( 'Expires: ' . gmdate( 'D, d M Y H:i:s', time() + YEAR_IN_SECONDS ) . ' GMT' );
 			echo wp_get_custom_css(); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
-			exit;
+			exit( 0 );
 		}
 
 		/**

projects/packages/jetpack-mu-wpcom/src/features/random-redirect/random-redirect.php

@@ -96,7 +96,7 @@ function jetpack_matt_random_redirect() {
 	// @phan-suppress-next-line PhanTypeMismatchArgument
 	$permalink = get_permalink( $random_id );
 	wp_safe_redirect( $permalink );
-	exit;
+	exit( 0 );
 }
 
 add_action( 'template_redirect', 'jetpack_matt_random_redirect' );

projects/packages/jetpack-mu-wpcom/src/features/wpcom-block-editor/class-jetpack-wpcom-block-editor.php

@@ -128,11 +128,11 @@ private function check_iframe_cookie_setting() {
 
 		if ( isset( $_SERVER['REQUEST_URI'] ) && empty( $_GET['calypsoify_cookie_check'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
 			header( 'Location: ' . esc_url_raw( wp_unslash( $_SERVER['REQUEST_URI'] ) . '&calypsoify_cookie_check=true' ) );
-			exit;
+			exit( 0 );
 		}
 
 		header( 'X-Frame-Options: DENY' );
-		exit;
+		exit( 0 );
 	}
 
 	/**
@@ -210,7 +210,7 @@ public function add_login_html() {
 	 */
 	public function do_redirect() {
 		wp_safe_redirect( $GLOBALS['redirect_to'] );
-		exit;
+		exit( 0 );
 	}
 
 	/**

projects/packages/licensing/changelog/fix-functionify_and_statusify_exit_and_die

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Code: Use function-style exit() and die() with a default status code of 0.

projects/packages/licensing/src/class-licensing.php

@@ -353,7 +353,7 @@ public function handle_user_connected_redirect( $dest_url ) {
 			&& apply_filters( 'jetpack_connection_user_has_license', false, $licenses, $plugin_slug )
 		) {
 			wp_safe_redirect( '/wp-admin/admin.php?page=my-jetpack#/add-license' );
-			exit;
+			exit( 0 );
 		}
 	}
 }

projects/packages/masterbar/changelog/fix-functionify_and_statusify_exit_and_die

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Code: Use function-style exit() and die() with a default status code of 0.