Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart library: Improve overall test coverage #41449

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

annacmc
Copy link
Contributor

@annacmc annacmc commented Jan 31, 2025

Proposed changes:

  • This PR adds tests (and some small additions of roles and testing IDs) to the legend and tooltip components

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Run tests for the charts package:
cd projects/js-packages/charts
pnpm test

Verify that all tests run successfully and pass.

In your Jetpack local env, navigate to the Storybook development environment:

pnpm i
cd projects/js-packages/storybook
pnpm run storybook:dev

Find JS Packages/Charts/ in the sidebar then navigate through the different charts, to check everything still works as expected.

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/js-packages/charts/src/components/legend/base-legend.tsx 10/10 (100.00%) 10.00% -1 💚
projects/js-packages/charts/src/components/tooltip/base-tooltip.tsx 4/4 (100.00%) 50.00% -2 💚

Full summary · JS report

@annacmc annacmc changed the title Add/chart library improve overall test coverage Chart library: Improve overall test coverage Jan 31, 2025
@annacmc annacmc marked this pull request as ready for review January 31, 2025 03:11
@annacmc annacmc requested review from kangzj, grzegorz-cp and a team January 31, 2025 03:12
@annacmc annacmc self-assigned this Jan 31, 2025
Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@annacmc annacmc merged commit 7063861 into trunk Jan 31, 2025
62 of 63 checks passed
@annacmc annacmc deleted the add/chart-library-improve-overall-test-coverage branch January 31, 2025 04:04
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] In Progress labels Jan 31, 2025
jboland88 pushed a commit that referenced this pull request Feb 3, 2025
* add tooltip tests

* add legend testing

* changelog

* add additional legend tests
@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Charts RNA [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants