-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert file field changes #41590
Revert file field changes #41590
Conversation
This reverts commit c89a414.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 4 files.
|
@ramonjd discovered that this is a false alarm, I had something set in my environment that made the beta blocks available! |
Proposed changes:
Proposes reverting #41582 and #41586
From what I can see these PRs result in the file field block being available in production, while the PR implies they should be experimental/beta.
The main impact of this is that if a user has added this block, they'll see a message "Your site doesn't include support for the "jetpack/field-file" block" after this. The block won't appear in the frontend, but everything else (the editor, other blocks) works without issue
Other information:
Does this pull request change what data or activity we track or use?
No
Testing instructions: