Connection: add modal for disconnecting owner account #41923

bindlegirl · 2025-02-20T17:59:17Z

In #41520 we introduced the ability for connection owners to disconnect their accounts without the need to disconnect the site and reconnect it to get back to site-only state.

That change created a situation where other users could remain connected while the primary user was missing. This is particularly strange for secondary connected admins, who will see their accounts connected, but different features will require them to connect and show the account connection links.

This PR adds a new modal to the disconnect option that warns the connection owner that disconnecting their account will cause other users to be disconnected, too.

Proposed changes:

Added a new modal for connection owners who choose the Disconnect my user account option in the Manage Connection dialog.
New modal displays a warning and offers several options (Disconnecting, Stay connected, Transfer ownership, and View connected accounts)
In the case the user confirms disconnection, the expanded version of the disconnect_user_force() method will run. The new code inside the method will loop through all connected user accounts and disconnect them.
If any account fails to get disconnected, the owner will also remain connected.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Create a JN site and create several users with different roles. Connect at least two.
Try disconnecting a nonprimary account in My Jetpack; it should work the same as before. Reconnect.
Try disconnecting the connection owner. Try all links. Make sure that confirming disconnect will disconnect all users.

github-actions · 2025-02-20T18:00:08Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/disconnect-owner-disconnect-all branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/disconnect-owner-disconnect-all

bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/disconnect-owner-disconnect-all

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-02-20T18:00:22Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).