-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package/jetpack-mu-wpcom to php 8.1 #41928
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Good thinking, I agree!
The default assumption in the monorepo is that projects will match WordPress Core's PHP version requirement, which is currently 7.2 or later. But since WordPress.com (both Simple and Atomic) uses 8.1, there's no point in restricting the code that's only intended for use there to passing linting and PHPCompatibility checks for earlier versions. |
BTW, for this to work you'll also need to include a9df08d. Feel free to make that another separate PR preceeding this one if you'd like. |
Significance: patch | ||
Type: changed | ||
|
||
Janitorial change: added PHPCS setting file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might change this to something like "Update minimum PHP version to 8.1." Same for the other change entries below. It doesn't matter a whole lot for these though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Totally fair. My thought was that it'd quickly unblock the PR to allow it to be merged rather than needing a rebase/merge from |
@anomiex I was looking at that one too, but was unsure how it was related. I opened a PR with just that commit: #41931. That PR is now the base branch for this PR. Is that what you meant? |
d972451
to
e983230
Compare
Rebased with trunk since #41931 was merged. |
Some lock files need updating. Otherwise LGTM. The "WordPress.com Tests" failing looks like the usual flakiness from that lately. Probably it'll pass on the re-run after you update the lock files. |
Updated the lock files using this message from the errors:
|
I've replied and addressed everything, but the github actions keep auto-adding needs author reply. I just self-assigned myself to see if it would consider me an author so it'll stop automatically changing tags on me. |
Proposed changes:
Require php 8.1 or higher on package/jetpack-mu-wpcom.
This change was originally made in #41770, but I think it should be its own PR since it doesn't really have to do with moving the theme api files.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: