-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WP_CLI_ALLOW_ROOT env var to Dockerfile #42007
Add WP_CLI_ALLOW_ROOT env var to Dockerfile #42007
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this might be needed too, we definitely need it in tools/docker/Dockerfile
.
(this tools/docker/Dockerfile.monorepo
is for the projects/js-packages/jetpack-cli/
stuff)
On second look, probably |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We set
WP_CLI_ALLOW_ROOT
in thedefault.env
file, but directly using the container would bypass that file (e.g. in our Post Build tests). This PR adds that env var to the Dockerfile.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
After merge, verify "Post Build tests" complete as expected.