Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling: Fix jetpack cli link and unlink #42130

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

tbradsha
Copy link
Contributor

This fixes pnpm jetpack cli link and jetpack cli unlink.

Proposed changes:

In #41821 we upgraded pnpm to v10 and removed the --global flag when linking since it wasn't supposed to need it anymore, but apparently this version didn't work as described. In pnpm v10.5 this was resolved (though that introduced a separate regression resolved in 10.5.2).

For now, we'll just keep the --global for the link. The unlink never seemed to work, and uninstall seems to work just as well, so I changed the script to use that.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Ensure jetpack isn't in your path/linked/aliased already (e.g. jetpack should give a "not found" error).
  2. Run pnpm jetpack cli link.
  3. Ensure jetpack runs as expected.
  4. Run jetpack cli unlink.
  5. Ensure jetpack no longer runs. Note that the error might have residual references to an npm path until you start a new terminal session; fixing that is out of scope and is likely a side effect of pnpm in general.

@tbradsha tbradsha added the [Type] Bug When a feature is broken and / or not performing as intended label Feb 27, 2025
@tbradsha tbradsha requested a review from a team February 27, 2025 22:14
@tbradsha tbradsha self-assigned this Feb 27, 2025
@github-actions github-actions bot added the [Tools] Development CLI The tools/cli to assist during JP development. label Feb 27, 2025
Copy link
Contributor

github-actions bot commented Feb 27, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 27, 2025
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Tools] Development CLI The tools/cli to assist during JP development. labels Feb 27, 2025
@github-actions github-actions bot added the [Tools] Development CLI The tools/cli to assist during JP development. label Feb 27, 2025
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Works well, thanks for all the digging you did to get to this solution!

@tbradsha tbradsha merged commit bddfa10 into trunk Feb 28, 2025
61 checks passed
@tbradsha tbradsha deleted the fix/tooling/cli_link_and_unlink branch February 28, 2025 14:22
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tools] Development CLI The tools/cli to assist during JP development. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants