-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect: Add E2E Tests #42197
base: trunk
Are you sure you want to change the base?
Protect: Add E2E Tests #42197
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Protect plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
I don't appear to be able to get the tests running locally and I don't see a line item in the PR checks for Jetpack Protect like for example Jetpack Boost has - does it make sense to separate them out early like that? If not, which of the E2E checks can I reference to verify that the tests are running/logging the results? |
f7f6603
to
16eb5e4
Compare
Added the config needed to get the tests running in GitHub, but they aren't passing 🤔 Works fine locally, getting some 404 errors when running in the cloud:
Still looking into it... |
@dkmyta Okay, all good for re-review here 👍 You should now see the Protect E2E tests running in GitHub along with the rest. Re: Running locally, here are some random tips from getting it going recently myself:
|
ee7def0
to
0c9a5b4
Compare
Proposed changes:
projects/plugins/protect/tests/e2e
, following the README with minor changes to the initial test style based on Explore usage of @wordpress/e2e-test-utils-playwright for E2E tests #40750.Other information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions: