Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Build arm image using ubuntu-24.04-arm runner #42212

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Mar 4, 2025

Proposed changes:

Linux arm64 runners are in public preview. Building the arm64 part of the Docker image on one of these rather than in qemu should be a lot faster; let's try it.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

none

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • See if the build worked and is faster.
  • Try the image and see if it works.

@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal labels Mar 4, 2025
@anomiex anomiex self-assigned this Mar 4, 2025
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@anomiex anomiex force-pushed the try/build-docker-with-ubuntu-24.04-arm-runner branch 7 times, most recently from 3e1abaf to 44a8e51 Compare March 4, 2025 22:21
Linux arm64 runners are in public preview. Building the arm64 part of
the Docker image on one of these rather than in qemu should be a lot
faster; let's try it.
@anomiex anomiex force-pushed the try/build-docker-with-ubuntu-24.04-arm-runner branch from 44a8e51 to ccdf3a3 Compare March 4, 2025 22:59
Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work for me (and ❤️ that build time).

@anomiex anomiex merged commit c1b97c0 into trunk Mar 5, 2025
67 checks passed
@anomiex anomiex deleted the try/build-docker-with-ubuntu-24.04-arm-runner branch March 5, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants