Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix critical css e2e on interstitial #42285

Closed
wants to merge 29 commits into from

Conversation

haqadn
Copy link
Contributor

@haqadn haqadn commented Mar 7, 2025

Fixes #

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

grzegorz-cp and others added 28 commits February 26, 2025 19:25
@haqadn haqadn self-assigned this Mar 7, 2025
@haqadn haqadn added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/fix-critical-css-e2e-on-interstitial branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/fix-critical-css-e2e-on-interstitial
bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/fix-critical-css-e2e-on-interstitial

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Package] My Jetpack [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests E2E Tests labels Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

  • Next scheduled release: March 19, 2025
  • Code freeze: March 17, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Mar 7, 2025

Code Coverage Summary

Coverage changed in 5 files.

File Coverage Δ% Δ Uncovered
projects/packages/my-jetpack/_inc/components/product-interstitial-modal/product-interstitial-my-jetpack.tsx 0/33 (0.00%) 0.00% 11 💔
projects/plugins/boost/app/assets/src/js/features/upgrade-cta/upgrade-cta.tsx 0/14 (0.00%) 0.00% 3 ❤️‍🩹
projects/plugins/boost/app/assets/src/js/features/error-boundary/error-boundary.tsx 0/9 (0.00%) 0.00% 2 ❤️‍🩹
projects/plugins/boost/app/assets/src/js/features/module/module.tsx 0/29 (0.00%) 0.00% 2 ❤️‍🩹
projects/plugins/boost/app/class-jetpack-boost.php 0/92 (0.00%) 0.00% 1 ❤️‍🩹

1 file is newly checked for coverage.

File Coverage
projects/plugins/boost/app/assets/src/js/features/upgrade-cta/interstitial-modal-cta.tsx 0/2 (0.00%) 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@dilirity
Copy link
Member

Closing this as the problem was fixed in the main PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Tests [Package] My Jetpack [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants