Cookie Consent: frontend Interactivity module [WOOA7S-1533]#49510
Draft
chihsuan wants to merge 7 commits into
Draft
Cookie Consent: frontend Interactivity module [WOOA7S-1533]#49510chihsuan wants to merge 7 commits into
chihsuan wants to merge 7 commits into
Conversation
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so: 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so: Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
…ssertion disables
7b27eb6 to
ad7eb5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of WOOA7S-1533 — migrating CIAB
shoppers-privacyinto the standalone, plugin-agnosticcookie-consentpackage. This is PR 2 of 3: the frontend WP Interactivity API script module (TypeScript + SCSS).Stack
trunk)add/cookie-consent-package)What this PR does
Ports the upstream frontend sources into
src/modules/cookie-consent/with a verbatim-copy → mechanical-rebrand commit discipline, so the divergence from upstream is reviewable commit-by-commit:ciab-nextsources (dir rename only) — the clean baselinecookie-consent→jetpack/cookie-consent; config globalwcConsentLoggerConfig→jetpackCookieConsentConfig(+ optionaleventPrefix)tracks-utils.tsreadswindow.jetpackCookieConsentConfig?.eventPrefix || 'jetpack'(was hardcodedwoocommerceanalytics), so consumers can brand their own eventswc-cookie-consent*/wc-ccpa-*/wc-gdpr-*→jetpack-cookie-consent*, in SCSS + JS selectorseslint-disabledirectives that are dead under jetpack's configwc_consent_id→jetpack_cookie_consent_idBuild emits LTR + RTL CSS and the script module;
eslint --max-warnings=0andtsgo --noEmitare clean.Notes
_stqWindow typedef is preserved).