Skip to content

fix: clear timeout in collection operations to prevent memory leak #15852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+16 −1
Open

fix: clear timeout in collection operations to prevent memory leak #15852

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba08ce0
fix: clear timeout in collection operations to prevent memory leak
techcodie Dec 2, 2025
ba491ca
revert: remove unrelated otherDbs changes
techcodie Dec 2, 2025
728e039
fix: resolve timeout variable scope issue
techcodie Dec 2, 2025
f826b66
Fix setTimeout memory leak in buffered collection operations
techcodie Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lib/drivers/node-mongodb-native/collection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ function iter(i) {

let _args = args;
let callback = null;
let timeout = null;
if (this._shouldBufferCommands() && this.buffer) {
this.conn.emit('buffer', {
_id: opId,
Expand All @@ -136,7 +137,6 @@ function iter(i) {
let callback;
let _args = args;
let promise = null;
let timeout = null;
if (syncCollectionMethods[i] && typeof lastArg === 'function') {
this.addQueue(i, _args);
callback = lastArg;
Expand Down Expand Up @@ -239,6 +239,9 @@ function iter(i) {

if (syncCollectionMethods[i] && typeof lastArg === 'function') {
const result = collection[i].apply(collection, _args.slice(0, _args.length - 1));
if (timeout != null) {
clearTimeout(timeout);
}
this.conn.emit('operation-end', { _id: opId, modelName: _this.modelName, collectionName: this.name, method: i, result });
return lastArg.call(this, null, result);
}
Expand All @@ -247,6 +250,9 @@ function iter(i) {
if (ret != null && typeof ret.then === 'function') {
return ret.then(
result => {
if (timeout != null) {
clearTimeout(timeout);
}
if (typeof lastArg === 'function') {
lastArg(null, result);
} else {
Expand All @@ -255,6 +261,9 @@ function iter(i) {
return result;
},
error => {
if (timeout != null) {
clearTimeout(timeout);
}
if (typeof lastArg === 'function') {
lastArg(error);
return;
Expand All @@ -265,10 +274,16 @@ function iter(i) {
}
);
}
if (timeout != null) {
clearTimeout(timeout);
}
return ret;
} catch (error) {
// Collection operation may throw because of max bson size, catch it here
// See gh-3906
if (timeout != null) {
clearTimeout(timeout);
}
if (typeof lastArg === 'function') {
return lastArg(error);
} else {
Expand Down