Skip to content

Comments

refactor(author-profile): move social button styles to plugin#412

Merged
rbcorrales merged 1 commit intotrunkfrom
refactor/move-social-styles-to-plugin
Feb 13, 2026
Merged

refactor(author-profile): move social button styles to plugin#412
rbcorrales merged 1 commit intotrunkfrom
refactor/move-social-styles-to-plugin

Conversation

@rbcorrales
Copy link
Member

@rbcorrales rbcorrales commented Feb 10, 2026

All Submissions:

Changes proposed in this Pull Request:

Removes the Author Profile social button styles from the theme. These styles are now provided by the social blocks themselves in newspack-plugin via a shared socialButton SCSS mixin, so they render consistently across all block themes without requiring theme-specific CSS.

Closes NPPD-1147.

Related PRs:

How to test the changes in this Pull Request:

Requires the companion newspack-blocks and newspack-plugin branches.

  1. Activate the block theme with all three companion branches.
  2. View an Author Profile block with social links on the frontend.
  3. Verify the social icons still have circular backgrounds with hover effects.
  4. Verify there is no duplicate or conflicting styling from the theme.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes theme-level styling for the Author Profile block’s social links so that social button styling is instead consistently provided by the newspack-plugin/social blocks (via a shared socialButton SCSS mixin), avoiding duplicate/conflicting CSS across themes.

Changes:

  • Deleted .wp-block-newspack-blocks-author-profile__social-links styling from the theme SCSS.
  • Removed the .has-background override that previously adjusted social link button colors via currentcolor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, @rbcorrales!

Sorry it's taken me so long to get to this collection of PRs - I'm slowly working on the other ones, but there's a lot of changes there and I'm a little slow 😅

@rbcorrales rbcorrales merged commit ff21a43 into trunk Feb 13, 2026
14 checks passed
@rbcorrales rbcorrales deleted the refactor/move-social-styles-to-plugin branch February 13, 2026 23:21
@github-actions
Copy link

🎉 This PR is included in version 1.25.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants