refactor(author-profile): move social button styles to plugin#412
refactor(author-profile): move social button styles to plugin#412rbcorrales merged 1 commit intotrunkfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes theme-level styling for the Author Profile block’s social links so that social button styling is instead consistently provided by the newspack-plugin/social blocks (via a shared socialButton SCSS mixin), avoiding duplicate/conflicting CSS across themes.
Changes:
- Deleted
.wp-block-newspack-blocks-author-profile__social-linksstyling from the theme SCSS. - Removed the
.has-backgroundoverride that previously adjusted social link button colors viacurrentcolor.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
laurelfulford
left a comment
There was a problem hiding this comment.
This is looking good, @rbcorrales!
Sorry it's taken me so long to get to this collection of PRs - I'm slowly working on the other ones, but there's a lot of changes there and I'm a little slow 😅
|
🎉 This PR is included in version 1.25.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Removes the Author Profile social button styles from the theme. These styles are now provided by the social blocks themselves in newspack-plugin via a shared
socialButtonSCSS mixin, so they render consistently across all block themes without requiring theme-specific CSS.Closes NPPD-1147.
Related PRs:
How to test the changes in this Pull Request:
Requires the companion newspack-blocks and newspack-plugin branches.
Other information: