feat: remove newspack-grid, newspack-grid-small, newspack-grid-sidebar#417
Open
thomasguillot wants to merge 5 commits intotrunkfrom
Open
feat: remove newspack-grid, newspack-grid-small, newspack-grid-sidebar#417thomasguillot wants to merge 5 commits intotrunkfrom
thomasguillot wants to merge 5 commits intotrunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This is a big one, so hopefully nothing’s broken.
This PR simplifies how columns are handled. I’ve removed the custom classes because it’s unlikely publishers will think to add them to their blocks, and they could easily be missed during migration. Instead, I’m targeting specific layouts directly, 25/50/25, 15/70/15, 33/66, and 66/33, and applying the grid to those.
The sidebar has been removed and replaced with the new grid. The same applies to newspack-grid-small, which felt redundant since the new grid covers those cases.
I’ve also removed the column patterns. Their main purpose was to include the newspack-grid class by default, but since that class is no longer used, keeping the patterns did not add much value.
Template parts have been checked to ensure everything still behaves as expected.
How to test the changes in this Pull Request:
Other information: