Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(homepage-articles): rename block and reorganise settings #2000

Merged
merged 10 commits into from
Feb 6, 2025

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

See #1943 for details

I just a few more changes based on the feedback received in p2

How to test the changes in this Pull Request:

See #1943 for details

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasguillot this is still really clean and the changes are much-needed and more user-friendly than before. I ran into a minor issue and had some non-blocking suggestions which you're welcome to dismiss if you disagree.

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasguillot thanks for the changes and feedback. Pre-approving this with some non-blocking suggestions—feel free to accept or reject, and merge when you decide!

@thomasguillot
Copy link
Contributor Author

Thank you so much for your suggestions (and review), @dkoo ❤️

@thomasguillot thomasguillot merged commit 841de19 into trunk Feb 6, 2025
7 checks passed
@thomasguillot thomasguillot deleted the update/homepage-posts-block-improvements branch February 6, 2025 21:56
Copy link

github-actions bot commented Feb 6, 2025

Hey @thomasguillot, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Feb 7, 2025
# [4.6.0-alpha.1](v4.5.10...v4.6.0-alpha.1) (2025-02-07)

### Bug Fixes

* enforce the password strength on checkout ([#2037](#2037)) ([b9dcf03](b9dcf03))
* make sure membership gate refreshes after variation purchase ([#2044](#2044)) ([1555b0f](1555b0f))
* remove OneSignal script from the modal checkout ([#2029](#2029)) ([343ca5e](343ca5e))
* return no posts for authors without term ([#2033](#2033)) ([e331139](e331139))

### Features

* **homepage-articles:** rename block and reorganise settings ([#2000](#2000)) ([841de19](841de19))
* rename all homepage posts patterns to content loop patterns ([#2046](#2046)) ([9b6bdee](9b6bdee))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.6.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 17, 2025
# [4.6.0](v4.5.10...v4.6.0) (2025-02-17)

### Bug Fixes

* enforce the password strength on checkout ([#2037](#2037)) ([b9dcf03](b9dcf03))
* make sure membership gate refreshes after variation purchase ([#2044](#2044)) ([1555b0f](1555b0f))
* remove OneSignal script from the modal checkout ([#2029](#2029)) ([343ca5e](343ca5e))
* return no posts for authors without term ([#2033](#2033)) ([e331139](e331139))

### Features

* **homepage-articles:** rename block and reorganise settings ([#2000](#2000)) ([841de19](841de19))
* rename all homepage posts patterns to content loop patterns ([#2046](#2046)) ([9b6bdee](9b6bdee))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants