fix: remove OneSignal script from the modal checkout

[laurelfulford]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

The OneSignal signup bell shows in the modal checkout; it shouldn't be loaded there.

See 1200550061930446-as-1209206364302813

How to test the changes in this Pull Request:

1. Install the OneSignal plugin and sign up for a free account.
2. Connected the account to your site (you have to fill out some forms and the site's URL, then copy the OneSignal App ID and OneSignal REST API Key to the WP Admin > One Signal page on your website.
3. In your OneSignal account, navigate to Settings > Push Platforms > Web, and add a Subscription Bell prompt under "Permission Prompt Setup".
4. View your site and confirm you have the little Subscription bell in the bottom right corner.
5. Run through a checkout using the modal checkout, and confirm the bell also appears there:

6. Apply this PR.
7. Repeat steps 4-5 and confirm the bell still shows on regular pages, but not in the modal checkout.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[leogermani]

I don't think we need to check for the active plugin here... if it's not, the hook will not be registered, nothing will be removed, and everything will be fine

[laurelfulford]

Ah good call, thanks @leogermani! I removed this check in 20f00c7 🙂

[laurelfulford]

Thanks @leogermani!

[github-actions]

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️