Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return no posts for authors without term #2033

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: return no posts for authors without term #2033

merged 1 commit into from
Jan 28, 2025

Conversation

leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

When using CAP, the HPP relies on the author terms to search for posts when filtered by authors.

As described in the docs, this requires the site to have created all terms for all authors in case they are missing, running wp co-authors-plus create-author-terms-for-posts.

However, for newly created users, or for users that are not authors of any posts, terms are not created.

The end result is that if you filter by such users, there will be no filter by the author taxonomy and all posts will be returned.

This PR fixes this.

How to test the changes in this Pull Request:

  1. on trunk
  2. Create a new user
  3. Add a HPP block anywhere and filter by this user.
  4. Note that all posts are returned
  5. checkout this branch
  6. note that no posts are returned, as expected

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani self-assigned this Jan 27, 2025
@leogermani leogermani requested a review from a team as a code owner January 27, 2025 20:09
@leogermani leogermani merged commit e331139 into trunk Jan 28, 2025
9 checks passed
@leogermani leogermani deleted the fix/hpp-author-no-posts branch January 28, 2025 13:54
@github-actions GitHub Actions
Copy link

Hey @leogermani, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

leogermani added a commit that referenced this pull request Jan 28, 2025
@leogermani
fix: return no posts for authors without term (#2033)
3b72633
@leogermani
Copy link
Contributor Author

cherry picked to current alphas

matticbot pushed a commit that referenced this pull request Jan 28, 2025
@semantic-release-bot
chore(release): 4.5.7-alpha.2 [skip ci]
3726c77 
## [4.5.7-alpha.2](v4.5.7-alpha.1...v4.5.7-alpha.2) (2025-01-28)

### Bug Fixes

* return no posts for authors without term ([#2033](#2033)) ([3b72633](3b72633))
matticbot pushed a commit that referenced this pull request Feb 3, 2025
@semantic-release-bot
chore(release): 4.5.9-alpha.1 [skip ci]
aaf36d4 
## [4.5.9-alpha.1](v4.5.8...v4.5.9-alpha.1) (2025-02-03)

### Bug Fixes

* add supported gateways check ([#2009](#2009)) ([1462233](1462233))
* return no posts for authors without term ([#2033](#2033)) ([3b72633](3b72633))
matticbot pushed a commit that referenced this pull request Feb 3, 2025
@semantic-release-bot
chore(release): 4.5.9 [skip ci]
656641d 
## [4.5.9](v4.5.8...v4.5.9) (2025-02-03)

### Bug Fixes

* add supported gateways check ([#2009](#2009)) ([1462233](1462233))
* return no posts for authors without term ([#2033](#2033)) ([3b72633](3b72633))
matticbot pushed a commit that referenced this pull request Feb 7, 2025
@semantic-release-bot
chore(release): 4.6.0-alpha.1 [skip ci]
5f59eee 
# [4.6.0-alpha.1](v4.5.10...v4.6.0-alpha.1) (2025-02-07)

### Bug Fixes

* enforce the password strength on checkout ([#2037](#2037)) ([b9dcf03](b9dcf03))
* make sure membership gate refreshes after variation purchase ([#2044](#2044)) ([1555b0f](1555b0f))
* remove OneSignal script from the modal checkout ([#2029](#2029)) ([343ca5e](343ca5e))
* return no posts for authors without term ([#2033](#2033)) ([e331139](e331139))

### Features

* **homepage-articles:** rename block and reorganise settings ([#2000](#2000)) ([841de19](841de19))
* rename all homepage posts patterns to content loop patterns ([#2046](#2046)) ([9b6bdee](9b6bdee))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.6.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

dkoo pushed a commit that referenced this pull request Feb 10, 2025
@leogermani @dkoo
fix: return no posts for authors without term (#2033)
8bb0adf
dkoo added a commit that referenced this pull request Feb 11, 2025
@dkoo @laurelfulford
@semantic-release-bot @dependabot @leogermani
fix(recaptcha): use clone of #place_order button to trigger checkout (#…
46eb8b5 
…2028)

* fix(recaptcha): use clone of #place_order button to trigger checkout

* chore: delete unwanted file

* fix(recaptcha): don't create button clone if not using v2

* fix: make sure fields after floated inputs clear floats in the modal checkout (#2030)

* chore(release): 4.5.6 [skip ci]

## [4.5.6](v4.5.5...v4.5.6) (2025-01-23)

### Bug Fixes

* make sure fields after floated inputs clear floats in the modal checkout ([#2030](#2030)) ([274b4d4](274b4d4))

* build(deps-dev): bump @testing-library/user-event from 14.6.0 to 14.6.1

Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 14.6.0 to 14.6.1.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md)
- [Commits](testing-library/user-event@v14.6...v14.6.1)

---
updated-dependencies:
- dependency-name: "@testing-library/user-event"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump lint-staged from 15.4.1 to 15.4.3

Bumps [lint-staged](https://github.com/lint-staged/lint-staged) from 15.4.1 to 15.4.3.
- [Release notes](https://github.com/lint-staged/lint-staged/releases)
- [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md)
- [Commits](lint-staged/lint-staged@v15.4.1...v15.4.3)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix: return no posts for authors without term (#2033)

* fix: remove OneSignal script from the modal checkout (#2029)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Laurel <[email protected]>
Co-authored-by: matticbot <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: leogermani <[email protected]>
matticbot pushed a commit that referenced this pull request Feb 17, 2025
@semantic-release-bot
chore(release): 4.6.0 [skip ci]
c6a0424 
# [4.6.0](v4.5.10...v4.6.0) (2025-02-17)

### Bug Fixes

* enforce the password strength on checkout ([#2037](#2037)) ([b9dcf03](b9dcf03))
* make sure membership gate refreshes after variation purchase ([#2044](#2044)) ([1555b0f](1555b0f))
* remove OneSignal script from the modal checkout ([#2029](#2029)) ([343ca5e](343ca5e))
* return no posts for authors without term ([#2033](#2033)) ([e331139](e331139))

### Features

* **homepage-articles:** rename block and reorganise settings ([#2000](#2000)) ([841de19](841de19))
* rename all homepage posts patterns to content loop patterns ([#2046](#2046)) ([9b6bdee](9b6bdee))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelpeixe miguelpeixe miguelpeixe approved these changes

Assignees

@leogermani leogermani

Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leogermani @matticbot @miguelpeixe