Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wcsg): respect checkbox label option in WCSG settings #2053

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Feb 12, 2025

All Submissions:

Changes proposed in this Pull Request:

There's an option in the WooCommerce Subscriptions Gifting (WCSG) extension that lets admins set the label of the gifting checkbox. This PR allows non-donation modal checkouts to show this label instead of a hardcoded label. The label is still hardcoded for donation checkouts, as the WCSG extension doesn't provide a filter for adding new custom options.

How to test the changes in this Pull Request:

Follow testing instructions in Automattic/newspack-plugin#3747

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Member

@naxoc naxoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this as part of #3747 and the modal worked great with this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants