fix: remove OneSignal v2 from modal checkout

[laurelfulford]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR expands on the change made here to remove OneSignal from the modal checkout, to make sure both v2 and v3 of the plugin code is removed.

See 1200550061930446-as-1209206364302813

How to test the changes in this Pull Request:

1. To recreate the testing setup for this bug, start with a site that hasn't run OneSignal before. You can also ping me for a JN site with this setup.
2. Download and install v 2.4.4 of OneSignal from here.
3. Sign up for a free account.
4. Connected the account to your site (you have to fill out some forms and the site's URL, then copy the OneSignal App ID and OneSignal REST API Key to the WP Admin > One Signal Push page on your website).
5. Enable the Subscription bell from the WP Admin > One Signal Push page:

6. Save the settings
7. View the site on the front-end and confirm that the bell is appearing.
8. Upgrade the plugin from 2.4.4 to the latest version. I ran into issues with this for some reason, but it worked if I downloaded some of the versions in between from here and uploaded them (though 3.0.0 threw a fatal).
9. Run through a modal checkout flow and confirm the bell appears in the modal.
10. Apply this PR.
11. Repeat step 8 and confirm that the bell no longer appears in the modal checkout.
12. Test on a second site with the latest version of OneSignal from the get-go, so it's loading the v3 version of the code.
13. Smoke test: retest reCAPTCHA for WooCommerce by following the steps here to make sure it's also still stripped out of the modal checkout, even though the hook changed. You can find a copy of that plugin attached to the Asana task.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[dkoo]

Works as described!

[laurelfulford]

Thanks @dkoo!

[github-actions]

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

[matticbot]

🎉 This PR is included in version 4.7.1-alpha.1 🎉

The release is available on:

• npm package (@alpha dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.7.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀