Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/user discrepancies display #100

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Feat/user discrepancies display #100

merged 3 commits into from
Jul 2, 2024

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented May 24, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

  1. Enables the "Newspack Network Activity" user column on nodes (previously it was only displayed on the hub)
  2. Enhances user count discrepancies debugging columns in the nodes list:
image

(Note: this is a part of integrating the changes from the data-integrity-improvements branch (#89))

How to test the changes in this Pull Request:

  1. On your network, create some user discrepancies by deleting some synchronized users directly in the DB (so the deletions are not synchronised), and adding some via CLI (so the additions are not synchronized)
  2. Visit the Nodes view in the hub site, appending a _newspack_user_discrepancies param
  3. Observe the discrepancies table as visible on the screenshot above, inspect the results to verify if the data matches your specific discrepancies
  4. Visit the WP Users view on both a node site and the hub site, observe the "Newspack Network Activity" column is present, with a "View All" link to the hub site's Event Log

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek requested a review from a team as a code owner May 24, 2024 08:52
dkoo
dkoo approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Non-blocking question: why hide the discrepancies column behind a URL param? It seems broadly useful.

dkoo
dkoo requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I think the counts are flipped. See below

includes/hub/admin/class-nodes-list.php Outdated Show resolved Hide resolved
@adekbadek adekbadek requested a review from dkoo July 1, 2024 07:09
@leogermani
Copy link
Contributor

any reason this PR is staled?

@dkoo
Copy link
Contributor

dkoo commented Jul 1, 2024

No reason—just fell off my radar.

@adekbadek adekbadek merged commit a054967 into trunk Jul 2, 2024
4 checks passed
@adekbadek adekbadek deleted the feat/user-discrepancies-display branch July 2, 2024 19:13
matticbot pushed a commit that referenced this pull request Jul 19, 2024
@semantic-release-bot
chore(release): 1.10.0-alpha.1 [skip ci]
10fd46a 
# [1.10.0-alpha.1](v1.9.2...v1.10.0-alpha.1) (2024-07-19)

### Features

* **membership-plans:** improvements  ([#110](#110)) ([f994478](f994478))
* user discrepancies display ([#100](#100)) ([a054967](a054967))
* **users:** bulk user network sync ([d1e9533](d1e9533))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.10.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 30, 2024
@semantic-release-bot
chore(release): 1.10.0 [skip ci]
b93f06d 
# [1.10.0](v1.9.2...v1.10.0) (2024-07-30)

### Features

* **membership-plans:** improvements  ([#110](#110)) ([f994478](f994478))
* user discrepancies display ([#100](#100)) ([a054967](a054967))
* **users:** bulk user network sync ([d1e9533](d1e9533))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adekbadek @leogermani @dkoo @matticbot