Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(content-distribution): confirm dialog for unlinking and relinking posts #190

Open
wants to merge 5 commits into
base: feat/content-distribution-editor-block
Choose a base branch
from
Open

feat(content-distribution): confirm dialog for unlinking and relinking posts #190

wants to merge 5 commits into from

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Jan 17, 2025 •
edited
Loading

1208510338230630-as-1209168371395426/f
p1737129121315119-slack-C055SRT7WN4

Introduces a confirmation dialog when unlinking and relinking posts.

link-confirm-dialog.mov

Testing

  1. Distribute a post and edit the post in the receiving node
  2. Click to unlink the post and confirm you get a confirmation dialog
  3. Cancel the dialog and confirm the dialog closes without further action
  4. Click again, click to unlink, and confirm the post gets unlinked
  5. Click to relink and confirm the confirmation dialog also behaves as expected

@miguelpeixe miguelpeixe requested a review from a team as a code owner January 17, 2025 16:23
@miguelpeixe miguelpeixe self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miguelpeixe miguelpeixe

Labels
[Status] Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miguelpeixe