feat(content-distribution): remove "Quick Edit" from linked posts #200
Conversation
Because quick edit let's the user do stuff we don't want on linked posts, this justs removes it. On a node site check that all linked posts don't show "quick edit" on hover on the posts listing. Networked posts that are not linked should have it.
| use Newspack\Data_Events; | ||
| use Newspack_Network\Admin as Network_Admin; | ||
| use Newspack_Network\Content_Distribution as Content_Distribution_Class; |
There was a problem hiding this comment.
We've not been using an alias for this in other files, should we start doing so? I thin it'd be good to standardize this.
There was a problem hiding this comment.
I agree. It's super confusing naming without it, so that's why I aliased it, but I'm up for either. Do you have a preference?
There was a problem hiding this comment.
I'm ok with the alias, do you mind doing the same for other files?
There was a problem hiding this comment.
Not at all. Will do and push to this one 👍
|
I aliased all the |
|
Hey @naxoc, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
# [2.6.0-alpha.1](v2.5.0...v2.6.0-alpha.1) (2025-02-07) ### Bug Fixes * **content-distribution:** use payload hash on partial updates ([#207](#207)) ([31b342d](31b342d)) * **event-log:** data css overflow ([#206](#206)) ([f81adfe](f81adfe)) ### Features * **content-distribution:** migration tweaks ([#201](#201)) ([9c61fa8](9c61fa8)) * **content-distribution:** partial payload ([#205](#205)) ([b844d06](b844d06)) * **content-distribution:** remove "Quick Edit" from linked posts ([#200](#200)) ([6ad3a4a](6ad3a4a)) * **content-distribution:** Sync authors ([#194](#194)) ([3156d35](3156d35)) * increase pull frequency and amount ([#209](#209)) ([6791da1](6791da1))
|
🎉 This PR is included in version 2.6.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [2.6.0](v2.5.0...v2.6.0) (2025-02-17) ### Bug Fixes * **content-distribution:** use payload hash on partial updates ([#207](#207)) ([31b342d](31b342d)) * **event-log:** data css overflow ([#206](#206)) ([f81adfe](f81adfe)) ### Features * **content-distribution:** migration tweaks ([#201](#201)) ([9c61fa8](9c61fa8)) * **content-distribution:** partial payload ([#205](#205)) ([b844d06](b844d06)) * **content-distribution:** remove "Quick Edit" from linked posts ([#200](#200)) ([6ad3a4a](6ad3a4a)) * **content-distribution:** Sync authors ([#194](#194)) ([3156d35](3156d35)) * increase pull frequency and amount ([#209](#209)) ([6791da1](6791da1))
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Because quick edit let's the user do stuff we don't want on linked posts, this just removes it.
How to test
On a node site check that all linked posts don't show "quick edit" on hover on the posts listing. Networked posts that are not linked should still have it.
Posts not networked should also have it (note that distributor also hides it, so not those posts).