Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-distribution): link to post on incoming #211

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

naxoc
Copy link
Member

@naxoc naxoc commented Feb 6, 2025

Small fix: the "View origin post" on incoming posts was linking to the original site, not post.

See pamTN9-aEn-p2#comment-13129

How to test

  • On an incoming post, click the button and verify that you are taken to the post and not the homepage

@naxoc naxoc self-assigned this Feb 6, 2025
@naxoc naxoc requested a review from a team as a code owner February 6, 2025 09:44
@naxoc naxoc requested a review from miguelpeixe February 7, 2025 10:06
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

originalUrl is also used when displaying the 'Originally distributed from %s.' and 'Distributed from %s.' notices.

We should expose originalSiteUrl and originalPostUrl.

@naxoc
Copy link
Member Author

naxoc commented Feb 12, 2025

We should expose originalSiteUrl and originalPostUrl.

Woops! Yes. Absolutely. I added that :)

@naxoc naxoc requested a review from miguelpeixe February 12, 2025 13:16
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for revising!

@naxoc naxoc merged commit 638fa8a into trunk Feb 12, 2025
4 checks passed
Copy link

Hey @naxoc, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

@naxoc naxoc deleted the fix/content-distribution-post-link-button branch February 12, 2025 13:24
matticbot pushed a commit that referenced this pull request Feb 20, 2025
# [2.7.0-alpha.1](v2.6.0...v2.7.0-alpha.1) (2025-02-20)

### Bug Fixes

* **content-distribution:** change link to edit origin post ([#215](#215)) ([ed70561](ed70561))
* **content-distribution:** link to post on incoming ([#211](#211)) ([638fa8a](638fa8a))
* **content-distribution:** sync non-publish posts ([#213](#213)) ([ba3cd6a](ba3cd6a))
* **content-distribution:** update icon to broadcast ([#214](#214)) ([df0e740](df0e740))

### Features

* **content-distribution:** default distribution status ([#216](#216)) ([df19856](df19856))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.7.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants