fix(content-distribution): sync non-publish posts #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naxoc
approved these changes
Feb 12, 2025
|
Hey @miguelpeixe, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Feb 20, 2025
# [2.7.0-alpha.1](v2.6.0...v2.7.0-alpha.1) (2025-02-20) ### Bug Fixes * **content-distribution:** change link to edit origin post ([#215](#215)) ([ed70561](ed70561)) * **content-distribution:** link to post on incoming ([#211](#211)) ([638fa8a](638fa8a)) * **content-distribution:** sync non-publish posts ([#213](#213)) ([ba3cd6a](ba3cd6a)) * **content-distribution:** update icon to broadcast ([#214](#214)) ([df0e740](df0e740)) ### Features * **content-distribution:** default distribution status ([#216](#216)) ([df19856](df19856))
|
🎉 This PR is included in version 2.7.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1208510338230630-as-1209335539861544
The logic to prevent distributing a post when it's not published is at the instantiation level for the Outgoing_Post object, which creates issues when an already published and distributed post moves to draft. We need to be able to instantiate the object, since it has already been distributed.
This causes issues when attempting to sync a distributed post when it moves to non-publish statuses.
This PR removes that restriction from the constructor and applies to the distribution API callback.
Testing
publish