Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-distribution): default distribution status #216

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Feb 13, 2025

Implement an option to set the default post status for distribution:

image

Also adds support for "pending" to be one of the options.

Testing

  1. Draft a new post and open the Distribution panel
  2. Confirm the default is draft
  3. Navigate to Newspack Network -> Distribute
  4. Confirm you see the new option as in the image above
  5. Change to pending
  6. Refresh the post editor and confirm the new default option is pending
  7. Back to the option, change it to publish
  8. Refresh the post editor and confirm it reflects the selected option

@miguelpeixe miguelpeixe self-assigned this Feb 13, 2025
@miguelpeixe miguelpeixe marked this pull request as ready for review February 13, 2025 19:48
@miguelpeixe miguelpeixe requested a review from a team as a code owner February 13, 2025 19:48
@thomasguillot
Copy link
Contributor

LGTM

@thomasguillot thomasguillot removed their request for review February 14, 2025 09:42
@miguelpeixe miguelpeixe requested a review from naxoc February 17, 2025 12:39
Copy link
Member

@naxoc naxoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Tested and works great.

@miguelpeixe miguelpeixe merged commit df19856 into trunk Feb 17, 2025
3 of 4 checks passed
@miguelpeixe miguelpeixe deleted the feat/content-distribution-default-status-2 branch February 17, 2025 13:35
Copy link

Hey @miguelpeixe, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Feb 20, 2025
# [2.7.0-alpha.1](v2.6.0...v2.7.0-alpha.1) (2025-02-20)

### Bug Fixes

* **content-distribution:** change link to edit origin post ([#215](#215)) ([ed70561](ed70561))
* **content-distribution:** link to post on incoming ([#211](#211)) ([638fa8a](638fa8a))
* **content-distribution:** sync non-publish posts ([#213](#213)) ([ba3cd6a](ba3cd6a))
* **content-distribution:** update icon to broadcast ([#214](#214)) ([df0e740](df0e740))

### Features

* **content-distribution:** default distribution status ([#216](#216)) ([df19856](df19856))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.7.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 4, 2025
# [2.7.0](v2.6.1...v2.7.0) (2025-03-04)

### Bug Fixes

* build on release ([#219](#219)) ([396cb61](396cb61))
* **content-distribution:** always distribute on API request ([#224](#224)) ([ea53b11](ea53b11))
* **content-distribution:** change link to edit origin post ([#215](#215)) ([ed70561](ed70561))
* **content-distribution:** ignore unchanged values when shortcircuiting meta ([#222](#222)) ([ed1182a](ed1182a))
* **content-distribution:** link to post on incoming ([#211](#211)) ([638fa8a](638fa8a))
* **content-distribution:** sync non-publish posts ([#213](#213)) ([ba3cd6a](ba3cd6a))
* **content-distribution:** update icon to broadcast ([#214](#214)) ([df0e740](df0e740))

### Features

* **content-distribution:** default distribution status ([#216](#216)) ([df19856](df19856))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants