Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build on release #219

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix: build on release #219

merged 1 commit into from
Feb 21, 2025

Conversation

miguelpeixe
Copy link
Member

Because of content distribution, we just recently started using js assets in the plugin. Releases are missing the dist/ directory because we're not building the assets on release. This PR fixes that.

See the CI job for reference: https://github.com/Automattic/newspack-scripts/blob/trunk/src/jobs/release.yml#L17

@miguelpeixe miguelpeixe self-assigned this Feb 21, 2025
@miguelpeixe miguelpeixe requested a review from a team as a code owner February 21, 2025 20:34
@miguelpeixe miguelpeixe merged commit 396cb61 into trunk Feb 21, 2025
4 checks passed
@miguelpeixe miguelpeixe deleted the fix/build-on-release branch February 21, 2025 21:43
Copy link

Hey @miguelpeixe, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Feb 21, 2025
# [2.7.0-alpha.2](v2.7.0-alpha.1...v2.7.0-alpha.2) (2025-02-21)

### Bug Fixes

* build on release ([#219](#219)) ([396cb61](396cb61))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.7.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@miguelpeixe
Copy link
Member Author

Confirmed that the new alpha (https://github.com/Automattic/newspack-network/releases/tag/v2.7.0-alpha.2) package includes the dist/ directory.

matticbot pushed a commit that referenced this pull request Mar 4, 2025
# [2.7.0](v2.6.1...v2.7.0) (2025-03-04)

### Bug Fixes

* build on release ([#219](#219)) ([396cb61](396cb61))
* **content-distribution:** always distribute on API request ([#224](#224)) ([ea53b11](ea53b11))
* **content-distribution:** change link to edit origin post ([#215](#215)) ([ed70561](ed70561))
* **content-distribution:** ignore unchanged values when shortcircuiting meta ([#222](#222)) ([ed1182a](ed1182a))
* **content-distribution:** link to post on incoming ([#211](#211)) ([638fa8a](638fa8a))
* **content-distribution:** sync non-publish posts ([#213](#213)) ([ba3cd6a](ba3cd6a))
* **content-distribution:** update icon to broadcast ([#214](#214)) ([df0e740](df0e740))

### Features

* **content-distribution:** default distribution status ([#216](#216)) ([df19856](df19856))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants