Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-distribution): handle incoming post object error #221

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

miguelpeixe
Copy link
Member

An exception might get thrown when instantiating an incoming post and it should be handled when processing the incoming events.

Testing

  1. Make sure you have define( 'NEWSPACK_NETWORK_DEBUG', true ); in your wp-config.php
  2. While on release, distribute a post to a node
  3. In the destination node, permanently delete (not just trash) the received post
  4. In the origin site, dispatch a partial update by updating a post meta: wp post meta update {post_id} test_meta test_value
  5. Confirm a fatal error is logged in the receiving node when processing the network_post_updated event
  6. Checkout this branch and repeat step 4
  7. Confirm the error is logged via the Debugger class

@miguelpeixe miguelpeixe self-assigned this Feb 26, 2025
@miguelpeixe miguelpeixe requested a review from a team as a code owner February 26, 2025 17:23
@miguelpeixe miguelpeixe merged commit b83b8f2 into release Feb 26, 2025
5 checks passed
@miguelpeixe miguelpeixe deleted the hotfix/handle-incoming-post-throw branch February 26, 2025 18:08
matticbot pushed a commit that referenced this pull request Feb 26, 2025
## [2.6.1](v2.6.0...v2.6.1) (2025-02-26)

### Bug Fixes

* **content-distribution:** handle incoming post object error ([#221](#221)) ([b83b8f2](b83b8f2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 26, 2025
# [2.7.0-alpha.3](v2.7.0-alpha.2...v2.7.0-alpha.3) (2025-02-26)

### Bug Fixes

* **content-distribution:** handle incoming post object error ([#221](#221)) ([b83b8f2](b83b8f2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.7.0-alpha.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants