fix(content-distribution): ignore unchanged values when shortcircuiting meta #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
deleted the
fix/content-distribution-fix-meta-shortcircuit
branch
|
Hey @miguelpeixe, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Feb 26, 2025
# [2.7.0-alpha.4](v2.7.0-alpha.3...v2.7.0-alpha.4) (2025-02-26) ### Bug Fixes * **content-distribution:** ignore unchanged values when shortcircuiting meta ([#222](#222)) ([ed1182a](ed1182a))
|
🎉 This PR is included in version 2.7.0-alpha.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Mar 4, 2025
# [2.7.0](v2.6.1...v2.7.0) (2025-03-04) ### Bug Fixes * build on release ([#219](#219)) ([396cb61](396cb61)) * **content-distribution:** always distribute on API request ([#224](#224)) ([ea53b11](ea53b11)) * **content-distribution:** change link to edit origin post ([#215](#215)) ([ed70561](ed70561)) * **content-distribution:** ignore unchanged values when shortcircuiting meta ([#222](#222)) ([ed1182a](ed1182a)) * **content-distribution:** link to post on incoming ([#211](#211)) ([638fa8a](638fa8a)) * **content-distribution:** sync non-publish posts ([#213](#213)) ([ba3cd6a](ba3cd6a)) * **content-distribution:** update icon to broadcast ([#214](#214)) ([df0e740](df0e740)) ### Features * **content-distribution:** default distribution status ([#216](#216)) ([df19856](df19856))
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not shortcircuit the distribution meta if it's unchanged or empty values. Gutenberg may send an empty array for
newspack_network_distributed_sites, which will reach the shortcircuit strategy and prevent the entire post save.Testing
I can't consistently reproduce the editor sending that empty array. Double-checking the new test assertions should be enough.